From 9ad26325be6cbb3be13b5d7194f59a2d7a7cea8e Mon Sep 17 00:00:00 2001 From: Jonathan Naylor Date: Wed, 4 Jul 2018 21:43:13 +0100 Subject: [PATCH 1/2] Update the StopWatch code. --- StopWatch.cpp | 17 ++++++++--------- StopWatch.h | 4 ++-- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/StopWatch.cpp b/StopWatch.cpp index 77d539d..eb32961 100644 --- a/StopWatch.cpp +++ b/StopWatch.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2015,2016 by Jonathan Naylor G4KLX + * Copyright (C) 2015,2016,2018 by Jonathan Naylor G4KLX * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -52,6 +52,7 @@ unsigned int CStopWatch::elapsed() #else #include +#include CStopWatch::CStopWatch() : m_start() @@ -64,21 +65,19 @@ CStopWatch::~CStopWatch() unsigned long CStopWatch::start() { - ::gettimeofday(&m_start, NULL); + ::clock_gettime(CLOCK_MONOTONIC, &m_start); - return m_start.tv_usec; + return m_start.tv_sec * 1000UL + m_start.tv_nsec / 1000000UL; } unsigned int CStopWatch::elapsed() { - struct timeval now; - ::gettimeofday(&now, NULL); + struct timespec now; + ::clock_gettime(CLOCK_MONOTONIC, &now); - unsigned int elapsed = (now.tv_sec - m_start.tv_sec) * 1000U; - elapsed += now.tv_usec / 1000U; - elapsed -= m_start.tv_usec / 1000U; + int offset = ((now.tv_sec - m_start.tv_sec) * 1000000000UL + now.tv_nsec - m_start.tv_nsec ) / 1000000UL; - return elapsed; + return (unsigned int)offset; } #endif diff --git a/StopWatch.h b/StopWatch.h index 811047e..554f91c 100644 --- a/StopWatch.h +++ b/StopWatch.h @@ -1,5 +1,5 @@ /* - * Copyright (C) 2015,2016 by Jonathan Naylor G4KLX + * Copyright (C) 2015,2016,2018 by Jonathan Naylor G4KLX * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -39,7 +39,7 @@ private: LARGE_INTEGER m_frequency; LARGE_INTEGER m_start; #else - struct timeval m_start; + struct timespec m_start; #endif }; From 6936b80c815245f4e27c49ee2f15d3580ba7e8da Mon Sep 17 00:00:00 2001 From: Jonathan Naylor Date: Sun, 15 Jul 2018 20:26:54 +0100 Subject: [PATCH 2/2] aSimplify the new stopwatch code. --- StopWatch.cpp | 44 +++++++++++++++++++++++++++++++++----------- StopWatch.h | 11 +++++++---- 2 files changed, 40 insertions(+), 15 deletions(-) diff --git a/StopWatch.cpp b/StopWatch.cpp index eb32961..481241b 100644 --- a/StopWatch.cpp +++ b/StopWatch.cpp @@ -21,21 +21,32 @@ #if defined(_WIN32) || defined(_WIN64) CStopWatch::CStopWatch() : -m_frequency(), +m_frequencyS(), +m_frequencyMS(), m_start() { - ::QueryPerformanceFrequency(&m_frequency); + ::QueryPerformanceFrequency(&m_frequencyS); + + m_frequencyMS.QuadPart = m_frequencyS.QuadPart / 1000ULL; } CStopWatch::~CStopWatch() { } -unsigned long CStopWatch::start() +unsigned long long CStopWatch::time() const +{ + LARGE_INTEGER now; + ::QueryPerformanceCounter(&now); + + return (unsigned long long)(now.QuadPart / m_frequencyMS.QuadPart); +} + +unsigned long long CStopWatch::start() { ::QueryPerformanceCounter(&m_start); - return (unsigned long)(m_start.QuadPart / m_frequency.QuadPart); + return (unsigned long long)(m_start.QuadPart / m_frequencyS.QuadPart); } unsigned int CStopWatch::elapsed() @@ -46,7 +57,7 @@ unsigned int CStopWatch::elapsed() LARGE_INTEGER temp; temp.QuadPart = (now.QuadPart - m_start.QuadPart) * 1000; - return (unsigned int)(temp.QuadPart / m_frequency.QuadPart); + return (unsigned int)(temp.QuadPart / m_frequencyS.QuadPart); } #else @@ -55,7 +66,7 @@ unsigned int CStopWatch::elapsed() #include CStopWatch::CStopWatch() : -m_start() +m_startMS(0ULL) { } @@ -63,11 +74,22 @@ CStopWatch::~CStopWatch() { } -unsigned long CStopWatch::start() +unsigned long long CStopWatch::time() const { - ::clock_gettime(CLOCK_MONOTONIC, &m_start); + struct timeval now; + ::gettimeofday(&now, NULL); - return m_start.tv_sec * 1000UL + m_start.tv_nsec / 1000000UL; + return now.tv_sec * 1000ULL + now.tv_usec / 1000ULL; +} + +unsigned long long CStopWatch::start() +{ + struct timespec now; + ::clock_gettime(CLOCK_MONOTONIC, &now); + + m_startMS = now.tv_sec * 1000ULL + now.tv_nsec / 1000000ULL; + + return m_startMS; } unsigned int CStopWatch::elapsed() @@ -75,9 +97,9 @@ unsigned int CStopWatch::elapsed() struct timespec now; ::clock_gettime(CLOCK_MONOTONIC, &now); - int offset = ((now.tv_sec - m_start.tv_sec) * 1000000000UL + now.tv_nsec - m_start.tv_nsec ) / 1000000UL; + unsigned long long nowMS = now.tv_sec * 1000ULL + now.tv_nsec / 1000000ULL; - return (unsigned int)offset; + return nowMS - m_startMS; } #endif diff --git a/StopWatch.h b/StopWatch.h index 554f91c..3f8fa19 100644 --- a/StopWatch.h +++ b/StopWatch.h @@ -31,15 +31,18 @@ public: CStopWatch(); ~CStopWatch(); - unsigned long start(); - unsigned int elapsed(); + unsigned long long time() const; + + unsigned long long start(); + unsigned int elapsed(); private: #if defined(_WIN32) || defined(_WIN64) - LARGE_INTEGER m_frequency; + LARGE_INTEGER m_frequencyS; + LARGE_INTEGER m_frequencyMS; LARGE_INTEGER m_start; #else - struct timespec m_start; + unsigned long long m_startMS; #endif };