MMDVM/MMDVMHost
1
0
Fork 0
mirror of https://github.com/g4klx/MMDVMHost synced 2025-12-21 23:45:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Bugfix in V/D 2 vote counting. Cast READ_BIT1() to bool.

Browse Source 
I was under the erroneous impression that READ_BIT1() would return
0 and 1. It turns out this is not the case -- it simply masks out
the desired bit without shifting to the right. Casting to bool yields
0 and 1 which we then can use to compute the sum.
This commit is contained in:
Mathias Weyland
2016-04-22 15:30:38 +02:00
parent 1852f140af
commit 8c33e57d63
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
YSFPayload.cpp
View File

@@ -395,7 +395,7 @@ void CYSFPayload::decodeVDMode2(unsigned char fn)
// errors += READ_BIT1(vch, 103); // Padding bit must be zero but apparently it is not...
for(unsigned int i = 0U; i < 81U; i += 3) {
uint8_t vote = READ_BIT1(vch, i) + READ_BIT1(vch, i+1) + READ_BIT1(vch, i+2);
uint8_t vote = bool(READ_BIT1(vch, i)) + bool(READ_BIT1(vch, i+1)) + bool(READ_BIT1(vch, i+2));
if(vote == 1 || vote == 2)
{
bool decision = vote / 2; // exploit integer division: 1/2 == 0, 2/2 == 1.