mirror of
https://github.com/OpenSquawk/OpenSquawk
synced 2026-07-30 13:16:31 +08:00
110616bc23
Phase 0 of the OpenSquawk repo separation. Everything happens inside the
monorepo so that the split itself becomes a mechanical path filter — filtering
first and repairing afterwards would leave two broken repos at once.
AUTH_MODE (0.1)
New server/utils/authMode.ts, session.ts and jwt.ts (the latter extracted
from auth.ts). requireUserSession now resolves in three steps: the app's own
session cookie, an app-minted bearer token, then the website access token.
Only the last one is transitional; it is marked PHASE 1 and disappears with
the User collection. The app's session is its own JWT in a host-only cookie
plus a short-lived bearer, so the existing Authorization call sites are
unchanged.
AUTH_MODE defaults to 'sso', not 'open' as the plan proposed: while the admin
and editor surface still lives here, an unset variable would otherwise serve
it to everyone as a local admin. requireAdmin additionally refuses in open
mode. Both are one-line removals in Phase 1 and marked as such.
SSO handoff (0.2)
Issuer: /api/service/auth/sso/{authorize,exchange}. Codes are stored as
SHA-256 hashes with a TTL index and claimed by a single atomic update, so
concurrent redemption cannot succeed twice. redirect_uri is matched against
SSO_REDIRECT_ORIGINS by exact origin — a prefix check would accept
app.opensquawk.de.evil.tld. There is no default and no wildcard: an empty
allowlist disables the handoff rather than opening a redirector.
Consumer: /api/auth/sso/callback plus app/pages/auth/callback.vue. The
browser only ever carries the code; it is redeemed server-to-server.
Hardcoded values and leaks (0.3)
Hotjar ID, the dome-light webhook URL and the bug-report recipient were
compiled in. All three are env-gated and off by default now, so a foreign
instance cannot ship analytics, cockpit telemetry or its users' bug reports
to us. Setting HOTJAR_ID, DOME_LIGHT_WEBHOOK_URL and BUG_REPORT_NOTIFY_EMAIL
restores the current behaviour on opensquawk.de.
Two databases, no shared Mongo (0.6)
AppUser mirrors an identity locally. Its _id is deliberately the SSO subject,
i.e. the website's User._id, so every existing LearnProfile, PilotProfile and
BridgeToken reference keeps resolving without a migration.
telemetry.ts mirrors records to the hosted service only when TELEMETRY_URL
and SERVICE_SECRET are both set — the self-host default is that nothing ever
leaves the instance. It writes locally first, buffers with a bound, drops on
overflow and never blocks the request path.
/api/service/user-deleted purges the app's half on account deletion. Unlike
telemetry this is deliberately loud: the admin delete aborts with the user
intact if the purge fails, because their id is the only handle for retrying.
?force=true overrides it and says so in the response.
Also here
/api/service/analytics/product-session was an unauthenticated public write
endpoint; it moves to /api/analytics/product-session behind the auth guard.
The bridge no longer populates against User but resolves through the mirror,
backfilling missing rows so live bridges never have to re-pair.
.claude/worktrees was tracked and would have reached the public repo.
scripts/split-paths.txt carries the filter list, verified by
scripts/verify-split-paths.mjs: every path exists, nothing website-only is
kept, and no kept file imports a dropped one. That check found real gaps —
tests/ cannot be taken wholesale, and two shared modules were missing. Ten
remaining edges are allowlisted, each annotated PHASE 1 in the code.
Open item, flagged and not resolved: flightlabTelemetryStore is an in-process
singleton written by the bridge (app) and read by FlightLab (website). Two
repos means two processes, so that read breaks regardless of which side it
lands on. FlightLab needs an HTTP path in Phase 2/3.
Verified: 609 tests pass, vue-tsc clean. Ran against two throwaway local
MongoDBs: open mode reaches /classroom and /live-atc with no login and
persists progress; the full SSO loop works and the mirror _id matches the
website User._id; lookalike origins, code reuse, forged codes and wrong
service secrets are all rejected; ingest is idempotent on bug-report code;
deletion purges all five collections; and with the app unreachable the admin
delete fails 502 with the user still present.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
99 lines
3.5 KiB
TypeScript
99 lines
3.5 KiB
TypeScript
import { describe, it } from 'node:test'
|
|
import assert from 'node:assert/strict'
|
|
|
|
import { BridgeToken } from '~~/server/models/BridgeToken'
|
|
import { getBridgeLog } from '~~/server/utils/bridgeLog'
|
|
|
|
function createEvent(headers: Record<string, string> = {}) {
|
|
return {
|
|
node: {
|
|
req: { headers },
|
|
},
|
|
context: {},
|
|
} as any
|
|
}
|
|
|
|
describe('/api/bridge/me handler', () => {
|
|
it('returns 401 when token header is missing', async () => {
|
|
;(globalThis as any).defineEventHandler = (handler: any) => handler
|
|
const mod = await import('~~/server/api/bridge/me.get')
|
|
const handler = mod.default
|
|
|
|
await assert.rejects(
|
|
() => handler(createEvent()),
|
|
(error: any) =>
|
|
error?.statusCode === 401 &&
|
|
error?.statusMessage === 'Unauthorized' &&
|
|
error?.message === 'x-bridge-token header fehlt oder ist ungültig.'
|
|
)
|
|
})
|
|
|
|
it('returns disconnected status when token has no linked user', async () => {
|
|
;(globalThis as any).defineEventHandler = (handler: any) => handler
|
|
const mod = await import('~~/server/api/bridge/me.get')
|
|
const handler = mod.default
|
|
|
|
// The handler no longer populates: it reads the raw reference and resolves
|
|
// it through resolveBridgeUser (AppUser mirror, see server/utils/bridge.ts).
|
|
const originalFindOne = (BridgeToken as any).findOne
|
|
;(BridgeToken as any).findOne = async () => ({
|
|
token: 'bridge-token-abc',
|
|
user: null,
|
|
connectedAt: new Date('2025-01-01T10:00:00.000Z'),
|
|
lastStatusAt: null,
|
|
})
|
|
|
|
try {
|
|
const result = await handler(createEvent({ 'x-bridge-token': 'bridge-token-abc' }))
|
|
assert.equal(result.connected, false)
|
|
assert.equal(result.user, null)
|
|
assert.equal(result.simConnected, false)
|
|
assert.equal(result.flightActive, false)
|
|
assert.equal(result.connectedAt, '2025-01-01T10:00:00.000Z')
|
|
|
|
const logs = getBridgeLog('bridge-token-abc')
|
|
assert.equal(logs.length > 0, true)
|
|
assert.match(logs[logs.length - 1]!.summary, /not connected/i)
|
|
} finally {
|
|
;(BridgeToken as any).findOne = originalFindOne
|
|
}
|
|
})
|
|
|
|
it('returns connected status with mapped user fields', async () => {
|
|
;(globalThis as any).defineEventHandler = (handler: any) => handler
|
|
const mod = await import('~~/server/api/bridge/me.get')
|
|
const handler = mod.default
|
|
|
|
// An already-resolved user object (as an AppUser document would be) is
|
|
// passed straight through by resolveBridgeUser — no DB round trip.
|
|
const originalFindOne = (BridgeToken as any).findOne
|
|
;(BridgeToken as any).findOne = async () => ({
|
|
token: 'bridge-token-live',
|
|
user: {
|
|
_id: '507f1f77bcf86cd799439055',
|
|
email: 'pilot@example.com',
|
|
name: 'Pilot',
|
|
},
|
|
simConnected: true,
|
|
flightActive: true,
|
|
connectedAt: undefined,
|
|
updatedAt: new Date('2025-01-01T11:00:00.000Z'),
|
|
lastStatusAt: new Date('2025-01-01T11:02:00.000Z'),
|
|
})
|
|
|
|
try {
|
|
const result = await handler(createEvent({ 'x-bridge-token': 'bridge-token-live' }))
|
|
assert.equal(result.connected, true)
|
|
assert.equal(result.user.id, '507f1f77bcf86cd799439055')
|
|
assert.equal(result.user.email, 'pilot@example.com')
|
|
assert.equal(result.user.name, 'Pilot')
|
|
assert.equal(result.simConnected, true)
|
|
assert.equal(result.flightActive, true)
|
|
assert.equal(result.connectedAt, '2025-01-01T11:00:00.000Z')
|
|
assert.equal(result.lastStatusAt, '2025-01-01T11:02:00.000Z')
|
|
} finally {
|
|
;(BridgeToken as any).findOne = originalFindOne
|
|
}
|
|
})
|
|
})
|