treat sysuid as string

This commit is contained in:
Reese Norris
2024-10-22 18:27:06 -07:00
parent 52bce0edf2
commit 1857df46f0
4 changed files with 35 additions and 38 deletions

View File

@@ -28,7 +28,7 @@ func TestParseClientIdentificationPDU(t *testing.T) {
MajorVersion: 1,
MinorVersion: 2,
CID: 1234567,
SysUID: 12345678,
SysUID: "12345678",
InitialChallenge: "abcd1234",
},
wantErr: nil,
@@ -70,10 +70,10 @@ func TestParseClientIdentificationPDU(t *testing.T) {
wantErr: NewGenericFSDError(SyntaxError, "XY", "invalid minor version"),
},
{
name: "Invalid SysUID - Non-numeric",
packet: "$IDCLIENT:SERVER:1234:ClientName:1:2:0001234:SYSUID:abcd1234\r\n",
name: "missing sysuid",
packet: "$IDCLIENT:SERVER:1234:ClientName:1:2:0001234::abcdefgh\r\n",
want: &ClientIdentificationPDU{},
wantErr: NewGenericFSDError(SyntaxError, "SYSUID", "invalid system UID"),
wantErr: NewGenericFSDError(SyntaxError, "", "validation error"),
},
{
name: "Invalid CID - too long",
@@ -131,7 +131,7 @@ func TestClientIdentificationPDU_Serialize(t *testing.T) {
MajorVersion: 1,
MinorVersion: 2,
CID: 1234567,
SysUID: 12345678,
SysUID: "12345678",
InitialChallenge: "abcd1234",
},
want: "$IDCLIENT:SERVER:1234:ClientName:1:2:1234567:12345678:abcd1234\r\n",