v0.1.0-alpha

Changes:
- Implement bootstrapping library for managing several concurrent internal services
- Refactor concurrency model for connections/logical clients and their associated I/O
- Refactor server context singleton
- Refactor error handling
    - Most errors are now gracefully sent to the FSD client directly encoded as an $ER packet,
      enhancing visibility and debugging
    - Most errors are now rightfully treated as non-fatal
- Refactor package/dependency graph
- Refactor calling conventions/interfaces for many packages
- Refactor database package
- Refactor post office

Features:
- Add VATSIM-esque HTTP/JSON "data feed"
- Add ephemeral in-memory database option
- Add user management REST API
- Add improved web interface
- Add MySQL support (drop SQLite support)

protocol/metar_request.go

@@ -6,26 +6,26 @@ import (
 )
 
 type MetarRequestPDU struct {
-	From    string `validate:"required,alphanum,max=7"`
-	To      string `validate:"required,alphanum,max=7"`
+	From    string `validate:"required,alphanum,max=16"`
+	To      string `validate:"required,alphanum,max=16"`
 	Station string `validate:"required,alphanum,max=4"`
 }
 
 func (p *MetarRequestPDU) Serialize() string {
-	return fmt.Sprintf("$AX%s:%s:METAR:%s%s", p.From, p.To, p.Station, PacketDelimeter)
+	return fmt.Sprintf("$AX%s:%s:METAR:%s%s", p.From, p.To, p.Station, PacketDelimiter)
 }
 
-func ParseMetarRequestPDU(rawPacket string) (*MetarRequestPDU, error) {
-	rawPacket = strings.TrimSuffix(rawPacket, PacketDelimeter)
-	rawPacket = strings.TrimPrefix(rawPacket, "$AX")
-	fields := strings.Split(rawPacket, Delimeter)
+func (p *MetarRequestPDU) Parse(packet string) error {
+	packet = strings.TrimSuffix(packet, PacketDelimiter)
+	packet = strings.TrimPrefix(packet, "$AX")
 
-	if len(fields) != 4 {
-		return nil, NewGenericFSDError(SyntaxError)
+	var fields []string
+	if fields = strings.Split(packet, Delimiter); len(fields) != 4 {
+		return NewGenericFSDError(SyntaxError, "", "invalid parameter count")
 	}
 
 	if fields[2] != "METAR" {
-		return nil, NewGenericFSDError(SyntaxError)
+		return NewGenericFSDError(SyntaxError, fields[2], "third parameter must be 'METAR'")
 	}
 
 	pdu := MetarRequestPDU{
@@ -34,10 +34,15 @@ func ParseMetarRequestPDU(rawPacket string) (*MetarRequestPDU, error) {
 		Station: fields[3],
 	}
 
-	err := V.Struct(pdu)
-	if err != nil {
-		return nil, NewGenericFSDError(SyntaxError)
+	if err := V.Struct(pdu); err != nil {
+		if validatorErr := getFSDErrorFromValidatorErrors(err); err != nil {
+			return validatorErr
+		}
+		return err
 	}
 
-	return &pdu, nil
+	// Copy new pdu into receiver
+	*p = pdu
+
+	return nil
 }