mirror of
https://github.com/renorris/openfsd
synced 2026-04-21 02:15:31 +08:00
v0.1.0-alpha
Changes:
- Implement bootstrapping library for managing several concurrent internal services
- Refactor concurrency model for connections/logical clients and their associated I/O
- Refactor server context singleton
- Refactor error handling
- Most errors are now gracefully sent to the FSD client directly encoded as an $ER packet,
enhancing visibility and debugging
- Most errors are now rightfully treated as non-fatal
- Refactor package/dependency graph
- Refactor calling conventions/interfaces for many packages
- Refactor database package
- Refactor post office
Features:
- Add VATSIM-esque HTTP/JSON "data feed"
- Add ephemeral in-memory database option
- Add user management REST API
- Add improved web interface
- Add MySQL support (drop SQLite support)
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
package protocol
|
||||
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/go-playground/validator/v10"
|
||||
@@ -28,61 +29,66 @@ func TestParsePlaneInfoRequestPDU(t *testing.T) {
|
||||
{
|
||||
name: "Last element not PIR",
|
||||
packet: "#SBPILOT:ATC:PI\r\n",
|
||||
want: nil,
|
||||
wantErr: NewGenericFSDError(SyntaxError),
|
||||
want: &PlaneInfoRequestPDU{},
|
||||
wantErr: NewGenericFSDError(SyntaxError, "PI", "third parameter must be 'PIR'"),
|
||||
},
|
||||
{
|
||||
name: "Missing To field",
|
||||
packet: "#SBPILOT::PIR\r\n",
|
||||
want: nil,
|
||||
wantErr: NewGenericFSDError(SyntaxError),
|
||||
want: &PlaneInfoRequestPDU{},
|
||||
wantErr: NewGenericFSDError(SyntaxError, "", "validation error"),
|
||||
},
|
||||
{
|
||||
name: "Missing From field",
|
||||
packet: "#SB:ATC:PIR\r\n",
|
||||
want: nil,
|
||||
wantErr: NewGenericFSDError(SyntaxError),
|
||||
want: &PlaneInfoRequestPDU{},
|
||||
wantErr: NewGenericFSDError(SyntaxError, "", "validation error"),
|
||||
},
|
||||
{
|
||||
name: "Extra fields",
|
||||
packet: "#SBPILOT:ATC:EXTRA:PIR\r\n",
|
||||
want: nil,
|
||||
wantErr: NewGenericFSDError(SyntaxError),
|
||||
want: &PlaneInfoRequestPDU{},
|
||||
wantErr: NewGenericFSDError(SyntaxError, "", "invalid parameter count"),
|
||||
},
|
||||
{
|
||||
name: "Invalid From field (non-alphanumerical)",
|
||||
packet: "#SBP!@#$:ATC:PIR\r\n",
|
||||
want: nil,
|
||||
wantErr: NewGenericFSDError(SyntaxError),
|
||||
want: &PlaneInfoRequestPDU{},
|
||||
wantErr: NewGenericFSDError(SyntaxError, "", "validation error"),
|
||||
},
|
||||
{
|
||||
name: "Invalid To field (too long)",
|
||||
packet: "#SBPILOT:12345678:PIR\r\n",
|
||||
want: nil,
|
||||
wantErr: NewGenericFSDError(SyntaxError),
|
||||
packet: "#SBPILOT:1234567812345678123456781234567812345678:PIR\r\n",
|
||||
want: &PlaneInfoRequestPDU{},
|
||||
wantErr: NewGenericFSDError(SyntaxError, "", "validation error"),
|
||||
},
|
||||
{
|
||||
name: "Input with incorrect prefix",
|
||||
packet: "$DIPILOT:ATC:PIR\r\n",
|
||||
want: nil,
|
||||
wantErr: NewGenericFSDError(SyntaxError),
|
||||
want: &PlaneInfoRequestPDU{},
|
||||
wantErr: NewGenericFSDError(SyntaxError, "", "validation error"),
|
||||
},
|
||||
}
|
||||
|
||||
for _, tc := range tests {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
// Perform the parsing
|
||||
result, err := ParsePlaneInfoRequestPDU(tc.packet)
|
||||
pdu := PlaneInfoRequestPDU{}
|
||||
err := pdu.Parse(tc.packet)
|
||||
|
||||
// Check the error
|
||||
if tc.wantErr != nil {
|
||||
assert.EqualError(t, err, tc.wantErr.Error())
|
||||
if strings.Contains(tc.wantErr.Error(), "validation error") {
|
||||
assert.Contains(t, err.Error(), "validation error")
|
||||
} else {
|
||||
assert.EqualError(t, err, tc.wantErr.Error())
|
||||
}
|
||||
} else {
|
||||
assert.NoError(t, err)
|
||||
}
|
||||
|
||||
// Verify the result
|
||||
assert.Equal(t, tc.want, result)
|
||||
assert.Equal(t, tc.want, &pdu)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user