mirror of
https://github.com/renorris/openfsd
synced 2026-03-22 14:35:36 +08:00
57d54d6705
Changes:
- Implement bootstrapping library for managing several concurrent internal services
- Refactor concurrency model for connections/logical clients and their associated I/O
- Refactor server context singleton
- Refactor error handling
- Most errors are now gracefully sent to the FSD client directly encoded as an $ER packet,
enhancing visibility and debugging
- Most errors are now rightfully treated as non-fatal
- Refactor package/dependency graph
- Refactor calling conventions/interfaces for many packages
- Refactor database package
- Refactor post office
Features:
- Add VATSIM-esque HTTP/JSON "data feed"
- Add ephemeral in-memory database option
- Add user management REST API
- Add improved web interface
- Add MySQL support (drop SQLite support)
121 lines
2.7 KiB
Go
121 lines
2.7 KiB
Go
package protocol
|
|
|
|
import (
|
|
"github.com/go-playground/validator/v10"
|
|
"github.com/stretchr/testify/assert"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestParseMetarResponsePDU(t *testing.T) {
|
|
V = validator.New(validator.WithRequiredStructEnabled())
|
|
|
|
tests := []struct {
|
|
name string
|
|
packet string
|
|
want *MetarResponsePDU
|
|
wantErr error
|
|
}{
|
|
{
|
|
"Valid - Standard Metar",
|
|
"$ARSERVER:CLIENT:KSEE 091847Z 25007KT 10SM SKC 24/04 A3006\r\n",
|
|
&MetarResponsePDU{
|
|
From: "SERVER",
|
|
To: "CLIENT",
|
|
Metar: "KSEE 091847Z 25007KT 10SM SKC 24/04 A3006",
|
|
},
|
|
nil,
|
|
},
|
|
{
|
|
"Valid - colons in metar",
|
|
"$ARSERVER:CLIENT:KSEE 091847Z::: 25007KT 10::SM SKC 24/:04 A3006\r\n",
|
|
&MetarResponsePDU{
|
|
From: "SERVER",
|
|
To: "CLIENT",
|
|
Metar: "KSEE 091847Z::: 25007KT 10::SM SKC 24/:04 A3006",
|
|
},
|
|
nil,
|
|
},
|
|
{
|
|
"Missing To field",
|
|
"$ARSERVER::KSEE 091847Z 25007KT 10SM SKC 24/04 A3006\r\n",
|
|
&MetarResponsePDU{},
|
|
NewGenericFSDError(SyntaxError, "", "validation error"),
|
|
},
|
|
{
|
|
"From Field too long",
|
|
"$ARSERVERTOLONGSERVERTOLONGSERVERTOLONG:CLIENT:KSEE 091847Z 25007KT 10SM SKC 24/04 A3006\r\n",
|
|
&MetarResponsePDU{},
|
|
NewGenericFSDError(SyntaxError, "", "validation error"),
|
|
},
|
|
{
|
|
"Metar too long",
|
|
"$ARSERVER:CLIENT:" + strings.Repeat("A", 1024) + "\r\n",
|
|
&MetarResponsePDU{},
|
|
NewGenericFSDError(SyntaxError, "", "validation error"),
|
|
},
|
|
{
|
|
"Incomplete packet format",
|
|
"$ARSERVER:CLIENT\r\n",
|
|
&MetarResponsePDU{},
|
|
NewGenericFSDError(SyntaxError, "", "invalid parameter count"),
|
|
},
|
|
{
|
|
"Empty metar field",
|
|
"$ARSERVER:CLIENT:\r\n",
|
|
&MetarResponsePDU{},
|
|
NewGenericFSDError(SyntaxError, "", "validation error"),
|
|
},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
// Perform the parsing
|
|
pdu := MetarResponsePDU{}
|
|
err := pdu.Parse(tc.packet)
|
|
|
|
// Check the error
|
|
if tc.wantErr != nil {
|
|
if strings.Contains(tc.wantErr.Error(), "validation error") {
|
|
assert.Contains(t, err.Error(), "validation error")
|
|
} else {
|
|
assert.EqualError(t, err, tc.wantErr.Error())
|
|
}
|
|
} else {
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
// Verify the result
|
|
assert.Equal(t, tc.want, &pdu)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestMetarResponsePDU_Serialize(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
pdu MetarResponsePDU
|
|
want string
|
|
}{
|
|
{
|
|
"Standard Metar",
|
|
MetarResponsePDU{
|
|
From: "SERVER",
|
|
To: "CLIENT",
|
|
Metar: "KSEE 091847Z 25007KT 10SM SKC 24/04 A3006",
|
|
},
|
|
"$ARSERVER:CLIENT:KSEE 091847Z 25007KT 10SM SKC 24/04 A3006\r\n",
|
|
},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
// Perform the serialization
|
|
got := tc.pdu.Serialize()
|
|
|
|
// Verify the result
|
|
assert.Equal(t, tc.want, got)
|
|
})
|
|
}
|
|
}
|