mirror of
https://github.com/renorris/openfsd
synced 2026-03-22 14:35:36 +08:00
Changes:
- Implement bootstrapping library for managing several concurrent internal services
- Refactor concurrency model for connections/logical clients and their associated I/O
- Refactor server context singleton
- Refactor error handling
- Most errors are now gracefully sent to the FSD client directly encoded as an $ER packet,
enhancing visibility and debugging
- Most errors are now rightfully treated as non-fatal
- Refactor package/dependency graph
- Refactor calling conventions/interfaces for many packages
- Refactor database package
- Refactor post office
Features:
- Add VATSIM-esque HTTP/JSON "data feed"
- Add ephemeral in-memory database option
- Add user management REST API
- Add improved web interface
- Add MySQL support (drop SQLite support)
164 lines
3.6 KiB
Go
164 lines
3.6 KiB
Go
package protocol
|
|
|
|
import (
|
|
"github.com/go-playground/validator/v10"
|
|
"github.com/stretchr/testify/assert"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestParseClientQueryResponsePDU(t *testing.T) {
|
|
V = validator.New(validator.WithRequiredStructEnabled())
|
|
|
|
tests := []struct {
|
|
name string
|
|
packet string
|
|
want *ClientQueryResponsePDU
|
|
wantErr error
|
|
}{
|
|
{
|
|
"Valid with Payload",
|
|
"$CRFROM:TO:FP:P12345\r\n",
|
|
&ClientQueryResponsePDU{
|
|
From: "FROM",
|
|
To: "TO",
|
|
QueryType: "FP",
|
|
Payload: "P12345",
|
|
},
|
|
nil,
|
|
},
|
|
{
|
|
"Valid without Payload",
|
|
"$CRFROM:TO:WH\r\n",
|
|
&ClientQueryResponsePDU{
|
|
From: "FROM",
|
|
To: "TO",
|
|
QueryType: "WH",
|
|
Payload: "",
|
|
},
|
|
nil,
|
|
},
|
|
{
|
|
"Invalid QueryType",
|
|
"$CRFROM:TO:XYZ\r\n",
|
|
&ClientQueryResponsePDU{},
|
|
NewGenericFSDError(SyntaxError, "XYZ", "invalid query type"),
|
|
},
|
|
{
|
|
"From field too long",
|
|
"$CRFROMFROMFROMFROMFROMFROMFROM:TO:WH\r\n",
|
|
&ClientQueryResponsePDU{},
|
|
NewGenericFSDError(SyntaxError, "", "validation error"),
|
|
},
|
|
{
|
|
"Missing QueryType",
|
|
"$CRFROM:TO:\r\n",
|
|
&ClientQueryResponsePDU{},
|
|
NewGenericFSDError(SyntaxError, "", "validation error"),
|
|
},
|
|
{
|
|
"Empty packet",
|
|
"\r\n",
|
|
&ClientQueryResponsePDU{},
|
|
NewGenericFSDError(SyntaxError, "", "invalid parameter count"),
|
|
},
|
|
{
|
|
"Missing From field",
|
|
"$CR:TO:WH\r\n",
|
|
&ClientQueryResponsePDU{},
|
|
NewGenericFSDError(SyntaxError, "", "validation error"),
|
|
},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
// Perform the parsing
|
|
pdu := ClientQueryResponsePDU{}
|
|
err := pdu.Parse(tc.packet)
|
|
|
|
// Check the error
|
|
if tc.wantErr != nil {
|
|
if strings.Contains(tc.wantErr.Error(), "validation error") {
|
|
assert.Contains(t, err.Error(), "validation error")
|
|
} else {
|
|
assert.EqualError(t, err, tc.wantErr.Error())
|
|
}
|
|
} else {
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
// Verify the result
|
|
assert.Equal(t, tc.want, &pdu)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestClientQueryResponsePDU_Serialize(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
pdu *ClientQueryResponsePDU
|
|
want string
|
|
}{
|
|
{
|
|
name: "Serialize with payload",
|
|
pdu: &ClientQueryResponsePDU{
|
|
From: "CLIENT",
|
|
To: "SERVER",
|
|
QueryType: "IP",
|
|
Payload: "192.0.2.1",
|
|
},
|
|
want: "$CRCLIENT:SERVER:IP:192.0.2.1\r\n",
|
|
},
|
|
{
|
|
name: "Serialize without payload",
|
|
pdu: &ClientQueryResponsePDU{
|
|
From: "CLIENT",
|
|
To: "SERVER",
|
|
QueryType: "IP",
|
|
Payload: "",
|
|
},
|
|
want: "$CRCLIENT:SERVER:IP\r\n",
|
|
},
|
|
{
|
|
name: "Serialize with minimum query type length",
|
|
pdu: &ClientQueryResponsePDU{
|
|
From: "CLIENT",
|
|
To: "SERVER",
|
|
QueryType: "C?",
|
|
Payload: "Question",
|
|
},
|
|
want: "$CRCLIENT:SERVER:C?:Question\r\n",
|
|
},
|
|
{
|
|
name: "Serialize with maximum query type length",
|
|
pdu: &ClientQueryResponsePDU{
|
|
From: "CLIENT",
|
|
To: "SERVER",
|
|
QueryType: "NEWINFO",
|
|
Payload: "Updates",
|
|
},
|
|
want: "$CRCLIENT:SERVER:NEWINFO:Updates\r\n",
|
|
},
|
|
{
|
|
name: "Serialize with non-alphanumeric characters in payload",
|
|
pdu: &ClientQueryResponsePDU{
|
|
From: "CLIENT",
|
|
To: "SERVER",
|
|
QueryType: "FP",
|
|
Payload: "FPL-ABCDE-IS -KJFK0740-N0460F330 BETTE4 BETTE ACK J174 LICKS N76B MICYY SH9",
|
|
},
|
|
want: "$CRCLIENT:SERVER:FP:FPL-ABCDE-IS -KJFK0740-N0460F330 BETTE4 BETTE ACK J174 LICKS N76B MICYY SH9\r\n",
|
|
},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
// Perform serialization
|
|
result := tc.pdu.Serialize()
|
|
|
|
// Verify the result
|
|
assert.Equal(t, tc.want, result)
|
|
})
|
|
}
|
|
}
|