From 00c5e989d2a6d09bad854dfa59580c31ea41a1aa Mon Sep 17 00:00:00 2001 From: Mat Sutcliffe Date: Wed, 24 Oct 2018 22:32:01 +0100 Subject: [PATCH] Ref T387 Use a C-style cast to work around a buggy clang warning. --- src/blackmisc/algorithm.h | 6 ++++-- src/blackmisc/metaclass.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/blackmisc/algorithm.h b/src/blackmisc/algorithm.h index 9c5351bad..b1742a228 100644 --- a/src/blackmisc/algorithm.h +++ b/src/blackmisc/algorithm.h @@ -151,7 +151,8 @@ namespace BlackMisc // parameter pack swallow idiom static_cast(std::initializer_list { - (static_cast(std::forward(visitor)(std::get(std::forward(tuple)))), 0)... + //! \fixme C-style cast is needed due to a clang bug: https://bugs.llvm.org/show_bug.cgi?id=39375 + ((void)(std::forward(visitor)(std::get(std::forward(tuple)))), 0)... }); } //! \private @@ -161,7 +162,8 @@ namespace BlackMisc // parameter pack swallow idiom static_cast(std::initializer_list { - (static_cast(std::forward(visitor)(std::get(std::forward(tuple)), std::get(std::forward(tuple)))), 0)... + //! \fixme C-style cast is needed due to a clang bug: https://bugs.llvm.org/show_bug.cgi?id=39375 + ((void)(std::forward(visitor)(std::get(std::forward(tuple)), std::get(std::forward(tuple)))), 0)... }); } } diff --git a/src/blackmisc/metaclass.h b/src/blackmisc/metaclass.h index 0d6a6bb60..25ee2f499 100644 --- a/src/blackmisc/metaclass.h +++ b/src/blackmisc/metaclass.h @@ -264,7 +264,8 @@ namespace BlackMisc // parameter pack swallow idiom static_cast(std::initializer_list { - (static_cast(std::forward(visitor)(members().at(index()))), 0)... + //! \fixme C-style cast is needed due to a clang bug: https://bugs.llvm.org/show_bug.cgi?id=39375 + ((void)(std::forward(visitor)(members().at(index()))), 0)... }); }