From 0cae43197cb45c95aec2986ae370e07fe58a14a2 Mon Sep 17 00:00:00 2001
From: Mathew Sutcliffe <oktal3700@gmail.com>
Date: Sun, 12 Nov 2017 21:20:09 +0000
Subject: [PATCH] Consume all console output of ping process, to avoid noise in
 test output.

---
 src/blackmisc/network/networkutils.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/blackmisc/network/networkutils.cpp b/src/blackmisc/network/networkutils.cpp
index 3600cd2a7..bab88e80d 100644
--- a/src/blackmisc/network/networkutils.cpp
+++ b/src/blackmisc/network/networkutils.cpp
@@ -61,20 +61,20 @@ namespace BlackMisc
         bool CNetworkUtils::canPing(const QString &hostAddress)
         {
             if (hostAddress.isEmpty()) { return false; }
-            QStringList params;
+            QProcess process;
+            process.setProgram("ping");
             if (CBuildConfig::isRunningOnWindowsNtPlatform())
             {
-                params << "-n" << "1";
+                process.setArguments({ "-n", "1", hostAddress });
             }
             else
             {
                 // all UNIX alike
-                params << "-c" << "1";
+                process.setArguments({ "-c", "1", hostAddress });
             }
-            params << hostAddress;
-
-            const int exitCode = QProcess::execute("ping", params);
-            return exitCode == 0;
+            process.start();
+            process.waitForFinished();
+            return process.exitCode() == 0;
         }
 
         bool CNetworkUtils::canPing(const CUrl &url)