Formatting #910

src/blackcore/simulator.h

@@ -236,7 +236,6 @@ namespace BlackCore
         Q_OBJECT
 
     public:
-
         //! Constructor
         //! \sa ISimulatorFactory::createListener().
         //! \note msvc2015: use inherited constructor

src/blackgui/components/settingssimulatorcomponent.cpp

@@ -17,13 +17,13 @@
 #include "blackgui/pluginconfigwindow.h"
 #include "blackgui/plugindetailswindow.h"
 #include "blackgui/pluginselector.h"
+#include "blackmisc/simulation/simulatorplugininfo.h"
+#include "blackmisc/simulation/simulatorplugininfolist.h"
 #include "blackmisc/iterator.h"
 #include "blackmisc/logmessage.h"
 #include "blackmisc/pq/length.h"
 #include "blackmisc/pq/time.h"
 #include "blackmisc/pq/units.h"
-#include "blackmisc/simulation/simulatorplugininfo.h"
-#include "blackmisc/simulation/simulatorplugininfolist.h"
 #include "blackmisc/statusmessage.h"
 #include "ui_settingssimulatorcomponent.h"
 
@@ -285,9 +285,10 @@ namespace BlackGui
 
         void CSettingsSimulatorComponent::ps_showPluginDetails(const QString &identifier)
         {
-            CSimulatorPluginInfoList simDrivers(getAvailablePlugins());
+            const CSimulatorPluginInfoList simDrivers(getAvailablePlugins());
-            auto selected = std::find_if(simDrivers.begin(), simDrivers.end(),
+            const auto selected = std::find_if(
-                                         [&identifier](const CSimulatorPluginInfo & info)
+                                      simDrivers.begin(), simDrivers.end(),
+                                      [&identifier](const CSimulatorPluginInfo & info)
             {
                 return info.getIdentifier() == identifier;
             });

src/blackmisc/iterator.h

@@ -7,9 +7,7 @@
  * contained in the LICENSE file.
  */
 
-/*!
+//! \file
-    \file
-*/
 
 #ifndef BLACKMISC_ITERATOR_H
 #define BLACKMISC_ITERATOR_H

src/blackmisc/simulation/fsx/simconnectutilities.h

@@ -12,9 +12,9 @@
 #ifndef BLACKMISC_SIMULATION_FSX_SIMCONNECTUTILITIES_H
 #define BLACKMISC_SIMULATION_FSX_SIMCONNECTUTILITIES_H
 
-#include "blackmisc/blackmiscexport.h"
 #include "blackmisc/aviation/aircraftlights.h"
 #include "blackmisc/weather/gridpoint.h"
+#include "blackmisc/blackmiscexport.h"
 
 #include <QMetaType>
 #include <QObject>

src/blackmisc/simulation/simulatorplugininfo.cpp

@@ -7,9 +7,7 @@
  * contained in the LICENSE file.
  */
 
-
 #include "blackmisc/simulation/simulatorplugininfo.h"
-
 #include <QJsonValue>
 #include <QtGlobal>
 

src/plugins/simulator/fsxcommon/simconnectsettingscomponent.cpp

@@ -162,13 +162,13 @@ namespace BlackSimPlugin
             if (sGui->getIContextApplication()->writeToFile(fileName, CSimConnectUtilities::simConnectCfg(address, p)))
             {
                 QMessageBox::information(qApp->activeWindow(), tr("File saved"),
-                                         tr("File %1 saved.").arg(fileName));
+                                         tr("File '%1' saved.").arg(fileName));
                 checkSimConnectCfgFile();
             }
             else
             {
                 QMessageBox::warning(qApp->activeWindow(), tr("Failed writing simConnect.cfg"),
-                                     tr("Failed writing %1!").arg(fileName));
+                                     tr("Failed writing '%1'!").arg(fileName));
             }
         }
     } // ns

src/plugins/simulator/fsxcommon/simulatorfsxcommon.cpp

@@ -10,8 +10,9 @@
 #include "simulatorfsxcommon.h"
 #include "blackcore/application.h"
 #include "blackmisc/network/textmessage.h"
-#include "blackmisc/simulation/fscommon/bcdconversions.h"
 #include "blackmisc/simulation/fsx/simconnectutilities.h"
+#include "blackmisc/simulation/fscommon/bcdconversions.h"
+#include "blackmisc/simulation/fscommon/fscommonutil.h"
 #include "blackmisc/simulation/aircraftmodel.h"
 #include "blackmisc/simulation/interpolatorlinear.h"
 #include "blackmisc/simulation/interpolatorspline.h"
@@ -22,7 +23,6 @@
 #include "blackmisc/logmessage.h"
 #include "blackmisc/threadutils.h"
 #include "blackmisc/verify.h"
-#include "blackmisc/simulation/fscommon/fscommonutil.h"
 
 #include <QTimer>
 #include <type_traits>

src/plugins/simulator/fsxcommon/simulatorfsxcommon.h

@@ -312,7 +312,8 @@ namespace BlackSimPlugin
             QString m_simulatorName;
             QString m_simulatorDetails;
 
-            //! SimConnect Callback
+            //! SimConnect Callback (simplified version for listener)
+            //! \sa CSimConnectObjects::SimConnectProc
             static void CALLBACK SimConnectProc(SIMCONNECT_RECV *pData, DWORD cbData, void *pContext);
         };
     }