From 12dedcbc6cc92c9a1307a068ad477921d96908af Mon Sep 17 00:00:00 2001
From: Roland Winklmeier <Roland.M.Winklmeier@gmail.com>
Date: Sun, 25 May 2014 13:35:07 +0200
Subject: [PATCH] Fix bug, which caused insert of invalid simconnect objects

---
 src/plugins/simulator/fsx/simulator_fsx.cpp | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/plugins/simulator/fsx/simulator_fsx.cpp b/src/plugins/simulator/fsx/simulator_fsx.cpp
index 23ac23824..020a8cb4e 100644
--- a/src/plugins/simulator/fsx/simulator_fsx.cpp
+++ b/src/plugins/simulator/fsx/simulator_fsx.cpp
@@ -321,15 +321,17 @@ namespace BlackSimPlugin
             SimConnect_SetDataOnSimObject(m_hSimConnect, CSimConnectDataDefinition::DataDefinitionGearHandlePosition, objectID, SIMCONNECT_DATA_SET_FLAG_DEFAULT, 0, sizeof(gearHandle), &gearHandle);
 
             CSimConnectObject simObject;
-            foreach(simObject, m_simConnectObjects)
+            auto it = m_simConnectObjects.begin();
+            for (; it != m_simConnectObjects.end(); ++it)
             {
-                if (simObject.getRequestId()== static_cast<int>(requestID))
+                if ((*it).getRequestId() == static_cast<int>(requestID))
                 {
-                    simObject.setObjectId(objectID);
+                    (*it).setObjectId(objectID);
                     break;
                 }
             }
-            m_simConnectObjects.insert(simObject.getCallsign(), simObject);
+            if (it != m_simConnectObjects.end())
+                m_simConnectObjects.insert(simObject.getCallsign(), simObject);
 
         }