Encode HTML messages, reported as bug in Discord

This commit is contained in:
Klaus Basan
2019-10-09 00:21:40 +02:00
committed by Mat Sutcliffe
parent 8a2d3458b4
commit 1ceac51771
4 changed files with 12 additions and 3 deletions

View File

@@ -101,7 +101,7 @@ namespace BlackGui
c = connect(sGui->getIContextOwnAircraft(), &IContextOwnAircraft::changedAircraftCockpit, this, &CTextMessageComponent::onChangedAircraftCockpit, Qt::QueuedConnection);
Q_ASSERT_X(c, Q_FUNC_INFO, "Missing connect");
}
Q_UNUSED(c);
Q_UNUSED(c)
// init by settings
const QPointer<CTextMessageComponent> myself(this);
@@ -267,7 +267,7 @@ namespace BlackGui
void CTextMessageComponent::onChangedAircraftCockpit(const CSimulatedAircraft &aircraft, const CIdentifier &originator)
{
// this is called for every overlay widget as well
Q_UNUSED(originator);
Q_UNUSED(originator)
if (!this->isActivated()) { return; }
this->showCurrentFrequenciesFromCockpit(aircraft);
}

View File

@@ -131,7 +131,7 @@ namespace BlackGui
html += u"<td class=\"recipient\">" % message.getRecipientCallsignOrFrequency() % u"</td>";
}
html += u"<td class=\"message\">" % message.getMessage() % u"</td></tr>";
html += u"<td class=\"message\">" % message.getHtmlEncodedMessage() % u"</td></tr>";
return html;
}

View File

@@ -164,6 +164,12 @@ namespace BlackMisc
return asciiOnlyString(simplifyAccents(m_message));
}
QString CTextMessage::getHtmlEncodedMessage() const
{
if (m_message.isEmpty()) { return {}; }
return m_message.toHtmlEscaped();
}
void CTextMessage::setMessage(const QString &message)
{
m_message = message.simplified().trimmed();

View File

@@ -90,6 +90,9 @@ namespace BlackMisc
//! Get ASCII only message
QString getAsciiOnlyMessage() const;
//! Get HTML escaped message
QString getHtmlEncodedMessage() const;
//! Empty message
bool isEmpty() const { return m_message.isEmpty(); }