From 1e0382463bd5622f5072ca828a9d8cdbe7744e16 Mon Sep 17 00:00:00 2001 From: Mat Sutcliffe Date: Tue, 10 Jun 2025 17:10:54 +0100 Subject: [PATCH] fix: copy QStringView by value --- src/misc/simulation/fscommon/fsdirectories.cpp | 6 +++--- src/misc/stringutils.cpp | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/misc/simulation/fscommon/fsdirectories.cpp b/src/misc/simulation/fscommon/fsdirectories.cpp index 5010bf20f..020e32d7d 100644 --- a/src/misc/simulation/fscommon/fsdirectories.cpp +++ b/src/misc/simulation/fscommon/fsdirectories.cpp @@ -653,7 +653,7 @@ namespace swift::misc::simulation::fscommon if (fileContent.isEmpty()) { continue; } const QList lines = splitLinesRefs(fileContent); static const QString p("Path="); - for (const QStringView &line : lines) + for (const QStringView line : lines) { const qsizetype i = line.lastIndexOf(p, -1, Qt::CaseInsensitive); if (i < 0 || line.endsWith('=')) { continue; } @@ -779,7 +779,7 @@ namespace swift::misc::simulation::fscommon const QString relPath = fsxFileInfo.absolutePath(); QSet paths; - for (const QStringView &line : lines) + for (const QStringView line : lines) { const qsizetype i1 = line.lastIndexOf(p, -1, Qt::CaseInsensitive); if (i1 < 0) { continue; } @@ -845,7 +845,7 @@ namespace swift::misc::simulation::fscommon const QString relPath = fsxFileInfo.absolutePath(); QSet paths; - for (const QStringView &line : lines) + for (const QStringView line : lines) { const qsizetype i1 = line.lastIndexOf(p, -1, Qt::CaseInsensitive); if (i1 < 0) { continue; } diff --git a/src/misc/stringutils.cpp b/src/misc/stringutils.cpp index 9712155d7..68a86d485 100644 --- a/src/misc/stringutils.cpp +++ b/src/misc/stringutils.cpp @@ -422,7 +422,7 @@ namespace swift::misc { QMap map; QList lines = splitLinesRefs(data); - for (const QStringView &l : lines) + for (const QStringView l : lines) { if (l.isEmpty()) { continue; } const qsizetype i = l.indexOf('=');