Some minor fixes (typos, doxygen, etc.) found during #846

src/blackcore/corefacadeconfig.cpp

@@ -35,13 +35,13 @@ namespace BlackCore
 
     CCoreFacadeConfig CCoreFacadeConfig::forCoreAllLocalInDBus(const QString &dbusBootstrapAddress)
     {
-        const CCoreFacadeConfig cfg = CCoreFacadeConfig(CCoreFacadeConfig(CCoreFacadeConfig::LocalInDbusServer, dbusBootstrapAddress));
+        const CCoreFacadeConfig cfg(CCoreFacadeConfig::LocalInDbusServer, dbusBootstrapAddress);
         return cfg;
     }
 
     CCoreFacadeConfig CCoreFacadeConfig::forCoreAllLocalInDBusNoAudio(const QString &dbusBootstrapAddress)
     {
-        CCoreFacadeConfig cfg = CCoreFacadeConfig(CCoreFacadeConfig(CCoreFacadeConfig::LocalInDbusServer, dbusBootstrapAddress));
+        CCoreFacadeConfig cfg(CCoreFacadeConfig::LocalInDbusServer, dbusBootstrapAddress);
         cfg.m_audio = CCoreFacadeConfig::NotUsed;
         return cfg;
     }

src/blackgui/components/aircraftpartshistory.cpp

@@ -112,7 +112,6 @@ namespace BlackGui
             const auto currentAircraftParts = sGui->getIContextNetwork()->getRemoteAircraftParts(cs, -1).frontOrDefault();
             const auto aircraftPartsHistory = sGui->getIContextNetwork()->getAircraftPartsHistory(cs);
 
-
             QString html;
             if (currentAircraftParts == CAircraftParts() && aircraftPartsHistory.isEmpty())
             {

src/blackgui/components/registercomponent.cpp

@@ -40,8 +40,8 @@ namespace BlackGui
 
         void CRegisterComponent::ps_update()
         {
-            if (!sGui) { return; }
+            // if not supported, do nothing
-            Q_ASSERT_X(sGui->supportsContexts(), Q_FUNC_INFO, "Application does not support contexts");
+            if (!sGui || !sGui->supportsContexts()) { return; }
             ui->tvp_RegisteredComponents->updateContainer(sGui->getIContextApplication()->getRegisteredApplications());
         }
     } // ns

src/blackgui/components/registercomponent.h

@@ -36,7 +36,7 @@ namespace BlackGui
             explicit CRegisterComponent(QWidget *parent = nullptr);
 
             //! Destructor
-            ~CRegisterComponent();
+            virtual ~CRegisterComponent();
 
         private slots:
             //! Update data

src/swiftcore/main.cpp

@@ -27,6 +27,7 @@ int main(int argc, char *argv[])
     //! [SwiftApplicationDemo]
     CGuiApplication::highDpiScreenSupport();
     QApplication qa(argc, argv);
+    Q_UNUSED(qa); // init of qa is required, but qa not used
     CGuiApplication a("swift core", CApplicationInfo::PilotClientCore, CIcons::swiftCore24());
     a.addWindowStateOption();
     a.addDBusAddressOption();
@@ -39,7 +40,11 @@ int main(int argc, char *argv[])
     a.useContexts(a.isParserOptionSet("coreaudio") ?
                   CCoreFacadeConfig::forCoreAllLocalInDBus(dBusAdress) :
                   CCoreFacadeConfig::forCoreAllLocalInDBusNoAudio(dBusAdress));
-    a.start();
+    if (!a.start())
+    {
+        a.gracefulShutdown();
+        return EXIT_FAILURE;
+    }
     //! [SwiftApplicationDemo]
 
     if (!QSystemTrayIcon::isSystemTrayAvailable())

src/swiftcore/swiftcore.h

@@ -41,7 +41,7 @@ public:
     CSwiftCore(QWidget *parent = nullptr);
 
     //! Destructor
-    ~CSwiftCore();
+    virtual ~CSwiftCore();
 
 private slots:
     //! \name PushButton slots

src/swiftdata/main.cpp

@@ -29,6 +29,7 @@ int main(int argc, char *argv[])
     CGuiApplication a("swift mapping tool", CApplicationInfo::MappingTool, CIcons::swiftDatabase48());
     a.setSignalStartupAutomatically(false); // application will signal startup on its own
     a.splashScreen(CIcons::swiftDatabase256());
+    a.parse();
     a.useWebDataServices(BlackCore::CWebReaderFlags::AllSwiftDbReaders, CDatabaseReaderConfigList::forMappingTool());
     if (!a.start()) { return EXIT_FAILURE; }
     CSwiftData w;