From 21068427b080562b38fa6044be81eb9e2fba7175 Mon Sep 17 00:00:00 2001 From: Klaus Basan Date: Tue, 24 Mar 2020 18:31:26 +0100 Subject: [PATCH] Demoted to BLACK_VERIFY_X (no ASSERT) --- src/blackgui/guiutility.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/blackgui/guiutility.cpp b/src/blackgui/guiutility.cpp index 7615f52a8..dae6e0616 100644 --- a/src/blackgui/guiutility.cpp +++ b/src/blackgui/guiutility.cpp @@ -291,8 +291,13 @@ namespace BlackGui QString t(title.trimmed().toLower().simplified()); QString c(comparison.trimmed().toLower().simplified()); - Q_ASSERT_X(!t.isEmpty(), Q_FUNC_INFO, "missing title"); - Q_ASSERT_X(!c.isEmpty(), Q_FUNC_INFO, "missing value"); + + // we should not have empty titles + BLACK_VERIFY_X(!t.isEmpty(), Q_FUNC_INFO, "missing title"); + BLACK_VERIFY_X(!c.isEmpty(), Q_FUNC_INFO, "missing comparison value"); + if (t.isEmpty() || c.isEmpty()) { return false; } + + // same? if (t == c) { return true; } // further unify