Fixes as discussed in the meeting

* hasXXMessage performance
* remove id ASSERT_X
This commit is contained in:
Klaus Basan
2015-10-01 17:53:11 +02:00
committed by Mathew Sutcliffe
parent b7002e275a
commit 2507ce6715
2 changed files with 8 additions and 12 deletions

View File

@@ -15,15 +15,10 @@ namespace BlackCore
{
void registerMetadata()
{
int id;
id = qRegisterMetaType<BlackCore::IVoiceChannel::ConnectionStatus>();
Q_ASSERT_X(id >= 1024, Q_FUNC_INFO, "wrong id for metatype");
id = qRegisterMetaType<BlackCore::INetwork::ConnectionStatus>();
Q_ASSERT_X(id >= 1024, Q_FUNC_INFO, "wrong id for metatype");
id = qRegisterMetaType<BlackCore::CWebReaderFlags::WebReaderFlag>();
Q_ASSERT_X(id >= 1024, Q_FUNC_INFO, "wrong id for metatype");
id = qRegisterMetaType<BlackCore::CWebReaderFlags::WebReader>();
Q_UNUSED(id);
qRegisterMetaType<IVoiceChannel::ConnectionStatus>();
qRegisterMetaType<BlackCore::INetwork::ConnectionStatus>();
qRegisterMetaType<BlackCore::CWebReaderFlags::WebReaderFlag>();
qRegisterMetaType<BlackCore::CWebReaderFlags::WebReader>();
}
bool isCurrentThreadObjectThread(QObject *toBeTested)

View File

@@ -28,17 +28,18 @@ namespace BlackMisc
bool CStatusMessageList::hasErrorMessages() const
{
return findBySeverity(CStatusMessage::SeverityError).size() > 0;
return this->contains(&CStatusMessage::getSeverity, CStatusMessage::SeverityError);
}
bool CStatusMessageList::hasWarningMessages() const
{
return findBySeverity(CStatusMessage::SeverityWarning).size() > 0;
return this->contains(&CStatusMessage::getSeverity, CStatusMessage::SeverityWarning);
}
bool CStatusMessageList::hasWarningOrErrorMessages() const
{
return hasErrorMessages() || hasWarningMessages();
return this->containsBy
([ = ](const CStatusMessage & m) { return m.getSeverity() == CStatusMessage::SeverityWarning || m.getSeverity() == CStatusMessage::SeverityError; });
}
void CStatusMessageList::addCategory(const CLogCategory &category)