Tweaks

* check if parent is null
* comments
* icon in column
* nullptr check in runtime based component

src/blackcore/airspace_monitor.cpp

@@ -35,6 +35,7 @@ namespace BlackCore
         this->connect(this->m_network, &INetwork::fsipirCustomPacketReceived, this, &CAirspaceMonitor::fsipirCustomPacketReceived);
         this->connect(this->m_network, &INetwork::serverReplyReceived, this, &CAirspaceMonitor::serverReplyReceived);
 
+        // AutoConnection: this should also avoid race conditions by updating the bookings
         this->connect(this->m_vatsimBookingReader, &CVatsimBookingReader::dataRead, this, &CAirspaceMonitor::receivedBookings);
     }
 

src/blackgui/runtimebasedcomponent.cpp

@@ -34,13 +34,13 @@ namespace BlackGui
 
     void CRuntimeBasedComponent::sendStatusMessage(const BlackMisc::CStatusMessage &statusMessage)
     {
-        Q_ASSERT(this->getIContextApplication());
+        if (!this->getIContextApplication()) return;
         this->getIContextApplication()->sendStatusMessage(statusMessage);
     }
 
     void CRuntimeBasedComponent::sendStatusMessages(const BlackMisc::CStatusMessageList &statusMessages)
     {
-        Q_ASSERT(this->getIContextApplication());
+        if (!this->getIContextApplication()) return;
         this->getIContextApplication()->sendStatusMessages(statusMessages);
     }
 

src/blackgui/timerbasedcomponent.cpp

@@ -13,7 +13,7 @@ namespace BlackGui
     CTimerBasedComponent::~CTimerBasedComponent()
     {
         this->m_timer->stop();
-        this->disconnect(this->parent());
+        if (this->parent()) this->disconnect(this->parent());
     }
 
     void CTimerBasedComponent::setUpdateInterval(int milliSeconds)

src/blackgui/userlistmodel.cpp

@@ -41,7 +41,7 @@ namespace BlackGui
             break;
 
         case UserShort:
-            this->m_columns.addColumn(CColumn("", CUser::IndexCallsignIcon));
+            this->m_columns.addColumn(CColumn(CUser::IndexCallsignIcon, true));
             this->m_columns.addColumn(CColumn("realname", CUser::IndexRealName));
             this->m_columns.addColumn(CColumn("callsign", CUser::IndexCallsign));
             break;