flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-04-02 23:25:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed clazy warnings: empty QStringLiteral.

Browse Source
This commit is contained in:
Mat Sutcliffe
2018-12-17 16:40:59 +00:00
parent 268d858e2d
commit 333ea1b8df
37 changed files with 81 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/blackmisc/db/artifact.cpp
View File

@@ -47,7 +47,7 @@ namespace BlackMisc
QString CArtifact::getFileSizeHumanReadable() const
{
if (m_size < 0) { return QStringLiteral(""); }
if (m_size < 0) { return {}; }
return CFileUtils::humanReadableFileSize(m_size);
}
@@ -208,14 +208,14 @@ namespace BlackMisc
QString CArtifact::versionNumberFromFilename(const QString &filename)
{
if (filename.isEmpty()) { return QStringLiteral(""); }
if (filename.isEmpty()) { return {}; }
// swift-installer-linux-64-0.7.3_2017-03-25_11-24-50.run
thread_local const QRegularExpression firstSegments("\\d+\\.\\d+\\.\\d+");
const QRegularExpressionMatch firstSegmentsMatch = firstSegments.match(filename);
if (!firstSegmentsMatch.hasMatch())
{
return QStringLiteral(""); // no version, invalid
return {}; // no version, invalid
}
QString v = firstSegmentsMatch.captured(0); // first 3 segments, like 0.9.3
if (!v.endsWith('.')) { v += '.'; }