Ref T310, removed "m_separator" from IMenuDelegate as it is not used

This commit is contained in:
Klaus Basan
2018-08-26 14:30:25 +02:00
parent 73ddec5147
commit 35b70db67d
13 changed files with 70 additions and 68 deletions

View File

@@ -83,18 +83,18 @@ namespace BlackGui
ui->tvp_AircraftModelsForVPilot->addFilterDialog();
// model menus
ui->comp_OwnAircraftModels->view()->setCustomMenu(new CShowSimulatorFileMenu(ui->comp_OwnAircraftModels->view(), this, true));
ui->comp_OwnAircraftModels->view()->setCustomMenu(new CShowSimulatorFileMenu(ui->comp_OwnAircraftModels->view(), this));
ui->comp_OwnAircraftModels->view()->setCustomMenu(new CMergeWithVPilotMenu(this));
ui->comp_OwnAircraftModels->view()->setCustomMenu(new COwnModelSetMenu(this, true));
ui->comp_OwnAircraftModels->view()->setCustomMenu(new CStashToolsMenu(this, false));
ui->comp_OwnAircraftModels->view()->setCustomMenu(new COwnModelSetMenu(this));
ui->comp_OwnAircraftModels->view()->setCustomMenu(new CStashToolsMenu(this));
ui->comp_OwnModelSet->view()->setCustomMenu(new CShowSimulatorFileMenu(ui->comp_OwnModelSet->view(), this, true));
ui->comp_OwnModelSet->view()->setCustomMenu(new CStashToolsMenu(this, true));
ui->comp_OwnModelSet->view()->setCustomMenu(new CShowSimulatorFileMenu(ui->comp_OwnModelSet->view(), this));
ui->comp_OwnModelSet->view()->setCustomMenu(new CStashToolsMenu(this));
ui->comp_StashAircraft->view()->setCustomMenu(new CShowSimulatorFileMenu(ui->comp_StashAircraft->view(), this, true));
ui->comp_StashAircraft->view()->setCustomMenu(new CApplyDbDataMenu(this, true));
ui->comp_StashAircraft->view()->setCustomMenu(new COwnModelSetMenu(this, true));
ui->comp_StashAircraft->view()->setCustomMenu(new CStashToolsMenu(this, false));
ui->comp_StashAircraft->view()->setCustomMenu(new CShowSimulatorFileMenu(ui->comp_StashAircraft->view(), this));
ui->comp_StashAircraft->view()->setCustomMenu(new CApplyDbDataMenu(this));
ui->comp_StashAircraft->view()->setCustomMenu(new COwnModelSetMenu(this));
ui->comp_StashAircraft->view()->setCustomMenu(new CStashToolsMenu(this));
// connects
connect(ui->editor_ModelMapping, &CModelMappingForm::requestStash, this, &CDbMappingComponent::stashCurrentModel);
@@ -159,8 +159,8 @@ namespace BlackGui
connect(ui->tvp_AircraftModelsForVPilot, &CAircraftModelView::toggledHighlightStashedModels, this, &CDbMappingComponent::onStashedModelsChangedTriggerDigest);
connect(ui->tvp_AircraftModelsForVPilot, &CAircraftModelView::requestUpdate, this, &CDbMappingComponent::requestVPilotDataUpdate);
ui->tvp_AircraftModelsForVPilot->setCustomMenu(new CMappingVPilotMenu(this, true));
ui->tvp_AircraftModelsForVPilot->setCustomMenu(new CStashToolsMenu(this, false));
ui->tvp_AircraftModelsForVPilot->setCustomMenu(new CMappingVPilotMenu(this));
ui->tvp_AircraftModelsForVPilot->setCustomMenu(new CStashToolsMenu(this));
ui->tvp_AircraftModelsForVPilot->setDisplayAutomatically(true);
ui->tvp_AircraftModelsForVPilot->addFilterDialog();
@@ -909,8 +909,8 @@ namespace BlackGui
return qobject_cast<CDbMappingComponent *>(this->parent());
}
CDbMappingComponent::CStashToolsMenu::CStashToolsMenu(CDbMappingComponent *mappingComponent, bool separator) :
BlackGui::Menus::IMenuDelegate(mappingComponent, separator)
CDbMappingComponent::CStashToolsMenu::CStashToolsMenu(CDbMappingComponent *mappingComponent) :
Menus::IMenuDelegate(mappingComponent)
{}
void CDbMappingComponent::CStashToolsMenu::customMenu(CMenuActions &menuActions)
@@ -1009,8 +1009,8 @@ namespace BlackGui
return qobject_cast<CDbMappingComponent *>(this->parent());
}
CDbMappingComponent::CMergeWithVPilotMenu::CMergeWithVPilotMenu(CDbMappingComponent *mappingComponent, bool separator) :
IMenuDelegate(mappingComponent, separator)
CDbMappingComponent::CMergeWithVPilotMenu::CMergeWithVPilotMenu(CDbMappingComponent *mappingComponent) :
IMenuDelegate(mappingComponent)
{
Q_ASSERT_X(mappingComponent, Q_FUNC_INFO, "Missing vPilot reader");
}

View File

@@ -111,7 +111,7 @@ namespace BlackGui
bool canAddToModelSetTab() const;
//! Current model view
BlackGui::Views::CAircraftModelView *currentModelView() const;
Views::CAircraftModelView *currentModelView() const;
//! Unvalidated consolidated aircraft model from the editor subparts (icao, distributor)
//! \note not guaranteed to be valid, just a snapshot of its current editor state
@@ -346,8 +346,8 @@ namespace BlackGui
{
public:
//! Constructor
CMappingVPilotMenu(CDbMappingComponent *mappingComponent, bool separator = true) :
BlackGui::Menus::IMenuDelegate(mappingComponent, separator)
CMappingVPilotMenu(CDbMappingComponent *mappingComponent) :
BlackGui::Menus::IMenuDelegate(mappingComponent)
{}
//! \copydoc IMenuDelegate::customMenu
@@ -366,14 +366,14 @@ namespace BlackGui
//! -# toggle stash auto filtering
//! -# show changed attributes
//! \note This is a specific menu for the CDbMappingComponent component
class CStashToolsMenu : public BlackGui::Menus::IMenuDelegate
class CStashToolsMenu : public Menus::IMenuDelegate
{
public:
//! Constructor
CStashToolsMenu(CDbMappingComponent *mappingComponent, bool separator = true);
CStashToolsMenu(CDbMappingComponent *mappingComponent);
//! \copydoc IMenuDelegate::customMenu
virtual void customMenu(BlackGui::Menus::CMenuActions &menuActions) override;
virtual void customMenu(Menus::CMenuActions &menuActions) override;
private:
//! Mapping component
@@ -388,12 +388,12 @@ namespace BlackGui
};
//! Menu for own model sets
class COwnModelSetMenu : public BlackGui::Menus::IMenuDelegate
class COwnModelSetMenu : public Menus::IMenuDelegate
{
public:
//! Constructor
COwnModelSetMenu(CDbMappingComponent *mappingComponent, bool separator = true) :
BlackGui::Menus::IMenuDelegate(mappingComponent, separator)
COwnModelSetMenu(CDbMappingComponent *mappingComponent) :
Menus::IMenuDelegate(mappingComponent)
{}
//! \copydoc IMenuDelegate::customMenu
@@ -407,16 +407,16 @@ namespace BlackGui
};
//! Apply DB data to selected models
class CApplyDbDataMenu : public BlackGui::Menus::IMenuDelegate
class CApplyDbDataMenu : public Menus::IMenuDelegate
{
public:
//! Constructor
CApplyDbDataMenu(CDbMappingComponent *mappingComponent, bool separator = true) :
BlackGui::Menus::IMenuDelegate(mappingComponent, separator)
CApplyDbDataMenu(CDbMappingComponent *mappingComponent) :
Menus::IMenuDelegate(mappingComponent)
{}
//! \copydoc IMenuDelegate::customMenu
virtual void customMenu(BlackGui::Menus::CMenuActions &menuActions) override;
virtual void customMenu(Menus::CMenuActions &menuActions) override;
private:
//! Mapping component
@@ -427,14 +427,14 @@ namespace BlackGui
//! Merge with vPilot data
//! \deprecated vPilot menus will be removed in the future
class CMergeWithVPilotMenu : public BlackGui::Menus::IMenuDelegate
class CMergeWithVPilotMenu : public Menus::IMenuDelegate
{
public:
//! Constructor
CMergeWithVPilotMenu(CDbMappingComponent *mappingComponent, bool separator = true);
CMergeWithVPilotMenu(CDbMappingComponent *mappingComponent);
//! \copydoc IMenuDelegate::customMenu
virtual void customMenu(BlackGui::Menus::CMenuActions &menuActions) override;
virtual void customMenu(Menus::CMenuActions &menuActions) override;
//! Mapping component
CDbMappingComponent *mappingComponent() const;

View File

@@ -49,7 +49,7 @@ namespace BlackGui
ui->tvp_OwnAircraftModels->setAircraftModelMode(CAircraftModelListModel::OwnAircraftModelMappingTool);
ui->tvp_OwnAircraftModels->addFilterDialog();
ui->tvp_OwnAircraftModels->setDisplayAutomatically(true);
ui->tvp_OwnAircraftModels->setCustomMenu(new CLoadModelsMenu(this, true));
ui->tvp_OwnAircraftModels->setCustomMenu(new CLoadModelsMenu(this));
ui->tvp_OwnAircraftModels->setSimulatorForLoading(ui->comp_SimulatorSelector->getValue());
connect(ui->tvp_OwnAircraftModels, &CAircraftModelView::requestUpdate, this, &CDbOwnModelsComponent::requestOwnModelsUpdate);
@@ -73,7 +73,7 @@ namespace BlackGui
}
// menu
ui->tvp_OwnAircraftModels->setCustomMenu(new CConsolidateWithDbDataMenu(ui->tvp_OwnAircraftModels, this, false));
ui->tvp_OwnAircraftModels->setCustomMenu(new CConsolidateWithDbDataMenu(ui->tvp_OwnAircraftModels, this));
}
CDbOwnModelsComponent::~CDbOwnModelsComponent()

View File

@@ -172,16 +172,16 @@ namespace BlackGui
//! The menu for loading and handling own models for mapping tasks
//! \note This is specific for that very component
class CLoadModelsMenu : public BlackGui::Menus::IMenuDelegate
class CLoadModelsMenu : public Menus::IMenuDelegate
{
public:
//! Constructor
CLoadModelsMenu(CDbOwnModelsComponent *ownModelsComponent, bool separator = true) :
BlackGui::Menus::IMenuDelegate(ownModelsComponent, separator)
CLoadModelsMenu(CDbOwnModelsComponent *ownModelsComponent) :
BlackGui::Menus::IMenuDelegate(ownModelsComponent)
{}
//! \copydoc IMenuDelegate::customMenu
virtual void customMenu(BlackGui::Menus::CMenuActions &menuActions) override;
virtual void customMenu(Menus::CMenuActions &menuActions) override;
private:
QList<QAction *> m_loadActions; //!< load actions

View File

@@ -64,8 +64,8 @@ namespace BlackGui
ui->tvp_OwnModelSet->menuAddItems(CAircraftModelView::MenuRemoveSelectedRows | CAircraftModelView::MenuMaterializeFilter);
ui->tvp_OwnModelSet->addFilterDialog();
ui->tvp_OwnModelSet->setCustomMenu(new CLoadModelSetMenu(this));
ui->tvp_OwnModelSet->setCustomMenu(new CConsolidateWithDbDataMenu(ui->tvp_OwnModelSet, this, true));
ui->tvp_OwnModelSet->setCustomMenu(new CConsolidateWithSimulatorModels(ui->tvp_OwnModelSet, this, false));
ui->tvp_OwnModelSet->setCustomMenu(new CConsolidateWithDbDataMenu(ui->tvp_OwnModelSet, this));
ui->tvp_OwnModelSet->setCustomMenu(new CConsolidateWithSimulatorModels(ui->tvp_OwnModelSet, this));
ui->tvp_OwnModelSet->menuAddItems(CAircraftModelView::MenuLoadAndSave);
ui->tvp_OwnModelSet->setSorting(CAircraftModel::IndexOrderString);
ui->tvp_OwnModelSet->initAsOrderable();

View File

@@ -177,8 +177,8 @@ namespace BlackGui
{
public:
//! Constructor
CLoadModelSetMenu(CDbOwnModelSetComponent *ownModelSetComponent, bool separator = true) :
Menus::IMenuDelegate(ownModelSetComponent, separator)
CLoadModelSetMenu(CDbOwnModelSetComponent *ownModelSetComponent) :
Menus::IMenuDelegate(ownModelSetComponent)
{}
//! \copydoc IMenuDelegate::customMenu