From 3603bbabe25d4b7c31ba317adbd30259233737e1 Mon Sep 17 00:00:00 2001 From: Roland Winklmeier Date: Fri, 19 Aug 2016 21:03:09 +0200 Subject: [PATCH] Rename CApplication member function to be better readable The combination of the method's name 'signalStartupAutomatically' and the default argument, I completely misunderstood the purpose of the method in case the argument was skipped. 'a.signalStartupAutomatically()' actually disabled automatic signaling. --- src/blackcore/application.cpp | 4 ++-- src/blackcore/application.h | 2 +- src/swiftguistandard/main.cpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/blackcore/application.cpp b/src/blackcore/application.cpp index db797b2d4..e5ed5c724 100644 --- a/src/blackcore/application.cpp +++ b/src/blackcore/application.cpp @@ -342,9 +342,9 @@ namespace BlackCore return false; } - void CApplication::signalStartupAutomatically(bool signal) + void CApplication::setSignalStartupAutomatically(bool enabled) { - this->m_signalStartup = signal; + this->m_signalStartup = enabled; } QString CApplication::getEnvironmentInfoString(const QString &separator) const diff --git a/src/blackcore/application.h b/src/blackcore/application.h index 7f8f7e061..469fad288 100644 --- a/src/blackcore/application.h +++ b/src/blackcore/application.h @@ -168,7 +168,7 @@ namespace BlackCore bool isRunningInDeveloperEnvironment() const { return this->m_devEnv; } //! Signal startup automatically or individually - void signalStartupAutomatically(bool signal = false); + void setSignalStartupAutomatically(bool enabled); //! Info string QString getEnvironmentInfoString(const QString &separator) const; diff --git a/src/swiftguistandard/main.cpp b/src/swiftguistandard/main.cpp index a294aaf86..edf34b00e 100644 --- a/src/swiftguistandard/main.cpp +++ b/src/swiftguistandard/main.cpp @@ -25,7 +25,7 @@ int main(int argc, char *argv[]) CGuiApplication::highDpiScreenSupport(); QApplication qa(argc, argv); CSwiftGuiStdApplication a; - a.signalStartupAutomatically(); // application will signal startup on its own + a.setSignalStartupAutomatically(false); // application will signal startup on its own a.splashScreen(":/own/icons/own/swift/swiftCirclePilotClient1024.png"); if (!a.start()) {