Fix cppcheck warnings and cleanup suppression config

- redundantAssignment
- knownConditionTrueFalse

src/blackgui/components/dbautostashingcomponent.cpp

@@ -237,9 +237,10 @@ namespace BlackGui
             const int all = models.size();
 
             // maximum
+            int max = CDbStashComponent::MaxModelPublished;
             const QString maxStr(ui->le_MaxModelsStashed->text());
             bool okMaxStr = true;
-            int max = maxStr.isEmpty() ? CDbStashComponent::MaxModelPublished : maxStr.toInt(&okMaxStr);
+            if (!maxStr.isEmpty()) { max = maxStr.toInt(&okMaxStr); }
             if (!okMaxStr || max > all) { max = all; }
 
             // override description

src/blackgui/components/settingscomponent.cpp

@@ -74,8 +74,7 @@ namespace BlackGui
 
         void CSettingsComponent::initActions()
         {
-            QAction *a = nullptr;
-            a = new QAction(this);
+            QAction *a = new QAction(this);
             a->setObjectName("overview");
             a->setShortcut(QKeySequence(Qt::ALT + Qt::Key_S, Qt::Key_O));
             connect(a, &QAction::triggered, this, &CSettingsComponent::onActionTriggered);