From 379c53e0ccd21f895a3507c29224a94aaceab9ae Mon Sep 17 00:00:00 2001 From: Klaus Basan Date: Thu, 21 Dec 2017 19:16:29 +0100 Subject: [PATCH] Ref T189 and review follow up, replacing the changed values seems to be 4x faster (tested in samples) --- src/blackcore/vatsim/networkvatlib.cpp | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/blackcore/vatsim/networkvatlib.cpp b/src/blackcore/vatsim/networkvatlib.cpp index f81122f41..1a58e85a9 100644 --- a/src/blackcore/vatsim/networkvatlib.cpp +++ b/src/blackcore/vatsim/networkvatlib.cpp @@ -759,17 +759,15 @@ namespace BlackCore void CNetworkVatlib::sendCustomFsinnReponse(const CCallsign &callsign) { Q_ASSERT_X(isConnected(), Q_FUNC_INFO, "Can't send to server when disconnected"); - const CSimulatedAircraft myAircraft(getOwnAircraft()); - QString modelString = myAircraft.getModel().getModelString(); - if (modelString.isEmpty()) { modelString = defaultModelString(); } - const QStringList data { { "0" }, - myAircraft.getAirlineIcaoCodeDesignator(), - myAircraft.getAircraftIcaoCodeDesignator(), - { "" }, { "" }, { "" }, { "" }, - myAircraft.getAircraftIcaoCombinedType(), - modelString - }; + static const QStringList dataTemplate{ "0", "", "", "", "", "", "", "", "" }; + const CSimulatedAircraft myAircraft(getOwnAircraft()); + + QStringList data(dataTemplate); + data[1] = myAircraft.getAirlineIcaoCodeDesignator(); + data[2] = myAircraft.getAircraftIcaoCodeDesignator(); + data[7] = myAircraft.getAircraftIcaoCombinedType(); + data[8] = myAircraft.hasModelString() ? myAircraft.getModel().getModelString() : defaultModelString(); sendCustomPacket(callsign, "FSIPI", data); }