refs #124 fixed wrongly named virtual methods which failed to override virtuals in the base class,

discovered thanks to the override keyword
This commit is contained in:
Mathew Sutcliffe
2014-02-16 23:50:32 +00:00
parent 4c16cc3a2e
commit 3c8d4819e9
4 changed files with 8 additions and 8 deletions

View File

@@ -154,7 +154,7 @@ namespace BlackMisc
/*
* Property by index (setter)
*/
void CServer::propertyByIndex(const QVariant &variant, int index)
void CServer::setPropertyByIndex(const QVariant &variant, int index)
{
switch (index)
{

View File

@@ -141,12 +141,12 @@ namespace BlackMisc
/*!
* \copydoc CValueObject::propertyByIndex(int)
*/
QVariant propertyByIndex(int index) const;
QVariant propertyByIndex(int index) const override;
/*!
* \copydoc CValueObject::propertyByIndex(const QVariant &, int index)
* \copydoc CValueObject::setPropertyByIndex(const QVariant &, int index)
*/
void propertyByIndex(const QVariant &variant, int index);
void setPropertyByIndex(const QVariant &variant, int index) override;
/*!
* \copydoc CValueObject::propertyByIndexAsString()

View File

@@ -182,7 +182,7 @@ namespace BlackMisc
/*
* Set property as index
*/
void CUser::propertyByIndex(const QVariant &variant, int index)
void CUser::setPropertyByIndex(const QVariant &variant, int index)
{
switch (index)
{

View File

@@ -172,10 +172,10 @@ namespace BlackMisc
void syncronizeData(CUser &otherUser);
//! \copydoc CValueObject::propertyByIndex(int)
QVariant propertyByIndex(int index) const;
virtual QVariant propertyByIndex(int index) const override;
//! \copydoc CValueObject::propertyByIndex(const QVariant, int)
void propertyByIndex(const QVariant &variant, int index);
//! \copydoc CValueObject::setPropertyByIndex(const QVariant, int)
virtual void setPropertyByIndex(const QVariant &variant, int index) override;
protected:
//! \copydoc CValueObject::convertToQString