flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-04-25 10:15:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

refs #937 Resolved clazy warnings: pass-by-value/reference.

Browse Source
This commit is contained in:
Mathew Sutcliffe
2017-04-15 01:26:30 +01:00
parent b7f69c6887
commit 3ea9e33e6b
69 changed files with 166 additions and 166 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/blackcore/vatsim/networkvatlib.cpp
View File

@@ -278,7 +278,7 @@ namespace BlackCore
}
}
QByteArray CNetworkVatlib::toFSD(QString qstr) const
QByteArray CNetworkVatlib::toFSD(const QString &qstr) const
{
Q_ASSERT_X(m_fsdTextCodec, Q_FUNC_INFO, "Missing codec");
return m_fsdTextCodec->fromUnicode(qstr);
@@ -289,7 +289,7 @@ namespace BlackCore
return toFSD(callsign.getStringAsSet());
}
std::function<const char **()> CNetworkVatlib::toFSD(QStringList qstrList) const
std::function<const char **()> CNetworkVatlib::toFSD(const QStringList &qstrList) const
{
QVector<QByteArray> bytesVec;
for (auto i = qstrList.cbegin(); i != qstrList.cend(); ++i)

4
src/blackcore/vatsim/networkvatlib.h
View File

@@ -163,9 +163,9 @@ namespace BlackCore
static void onCustomPacketReceived(VatSessionID, const char *callsign, const char *packetId, const char **data, int dataSize, void *cbvar);
//! @}
QByteArray toFSD(QString qstr) const;
QByteArray toFSD(const QString &qstr) const;
QByteArray toFSD(const BlackMisc::Aviation::CCallsign &callsign) const;
std::function<const char **()> toFSD(QStringList qstrList) const;
std::function<const char **()> toFSD(const QStringList &qstrList) const;
QString fromFSD(const char *cstr) const;
QStringList fromFSD(const char **cstrArray, int size) const;
bool isInterimPositionUpdateEnabledForServer() const;

2
src/blackcore/vatsim/vatsimdatafilereader.cpp
View File

@@ -245,7 +245,7 @@ namespace BlackCore
Section section = SectionNone;
QString currentLine; // declared outside of the for loop, to amortize the cost of allocation
for (QStringRef clRef : lines)
for (const QStringRef &clRef : lines)
{
if (this->isAbandoned())
{

2
src/blackcore/vatsim/vatsimstatusfilereader.cpp
View File

@@ -111,7 +111,7 @@ namespace BlackCore
CUrlList metarFileUrls;
QString currentLine; // declared outside of the for loop, to amortize the cost of allocation
for (QStringRef clRef : lines)
for (const QStringRef &clRef : lines)
{
if (this->isAbandoned())
{