refs #937 Resolved clazy warnings: pass-by-value/reference.

This commit is contained in:
Mathew Sutcliffe
2017-04-15 01:26:30 +01:00
parent b7f69c6887
commit 3ea9e33e6b
69 changed files with 166 additions and 166 deletions

View File

@@ -691,7 +691,7 @@ namespace BlackMisc
return i; // default
}
CAircraftModel CAircraftModel::fromDatabaseJson(const QJsonObject &json, const QString prefix)
CAircraftModel CAircraftModel::fromDatabaseJson(const QJsonObject &json, const QString &prefix)
{
const QString modelString(json.value(prefix + "modelstring").toString());
const QString modelDescription(json.value(prefix + "description").toString());

View File

@@ -399,7 +399,7 @@ namespace BlackMisc
static const QString &modelModeToString(ModelMode mode);
//! From swift DB JSON
static CAircraftModel fromDatabaseJson(const QJsonObject &json, const QString prefix = QString("mod_"));
static CAircraftModel fromDatabaseJson(const QJsonObject &json, const QString &prefix = QString("mod_"));
//! Split swift network string "DLH._STD [modelname]"
//! \return QStringList [0] livery code , [1] model string

View File

@@ -282,7 +282,7 @@ namespace BlackMisc
return sim;
}
CSimulatorInfo CSimulatorInfo::fromDatabaseJson(const QJsonObject &json, const QString prefix)
CSimulatorInfo CSimulatorInfo::fromDatabaseJson(const QJsonObject &json, const QString &prefix)
{
const bool fsx = CDatastoreUtility::dbBoolStringToBool(json.value(prefix + "simfsx").toString());
const bool fs9 = CDatastoreUtility::dbBoolStringToBool(json.value(prefix + "simfs9").toString());

View File

@@ -178,7 +178,7 @@ namespace BlackMisc
static const CSimulatorInfo &guessDefaultSimulator();
//! From database JSON
static CSimulatorInfo fromDatabaseJson(const QJsonObject &json, const QString prefix);
static CSimulatorInfo fromDatabaseJson(const QJsonObject &json, const QString &prefix);
private:
int m_simulator = static_cast<int>(None);

View File

@@ -37,12 +37,12 @@ namespace BlackMisc
return m_data.getNames(true);
}
void CSimulatorInternals::setSimulatorVersion(const QString versionInfo)
void CSimulatorInternals::setSimulatorVersion(const QString &versionInfo)
{
this->setValue("all/versionInfo", versionInfo);
}
void CSimulatorInternals::setSimulatorInstallationDirectory(const QString fullFilePath)
void CSimulatorInternals::setSimulatorInstallationDirectory(const QString &fullFilePath)
{
this->setValue("all/installDir", fullFilePath);
}

View File

@@ -72,13 +72,13 @@ namespace BlackMisc
QString getSimulatorVersion() const;
//! Simulator version info, something like "10.3.2"
void setSimulatorVersion(const QString versionInfo);
void setSimulatorVersion(const QString &versionInfo);
//! Path where simulator is installed
QString getSimulatorInstallationDirectory() const;
//! Path where simulator is installed
void setSimulatorInstallationDirectory(const QString fullFilePath);
void setSimulatorInstallationDirectory(const QString &fullFilePath);
//! \copydoc BlackMisc::Mixin::Index::propertyByIndex
CVariant propertyByIndex(const BlackMisc::CPropertyIndex &index) const;