diff --git a/src/blackgui/components/settingscomponent.cpp b/src/blackgui/components/settingscomponent.cpp index 85ab25e53..306faf3b6 100644 --- a/src/blackgui/components/settingscomponent.cpp +++ b/src/blackgui/components/settingscomponent.cpp @@ -52,31 +52,11 @@ namespace BlackGui return ui->comp_AudioSetup->playNotificationSounds(); } - /* - * Update own ICAO data from GUI - */ - void CSettingsComponent::setOwnAircraftIcaoDataFromGui(CAircraftIcao &icao) const - { - icao.setAirlineDesignator(this->ui->le_SettingsIcaoAirlineDesignator->text()); - icao.setAircraftDesignator(this->ui->le_SettingsIcaoAircraftDesignator->text()); - icao.setAircraftCombinedType(this->ui->le_SettingsIcaoCombinedType->text()); - } - void CSettingsComponent::setGuiOpacity(double value) { this->ui->hs_SettingsGuiOpacity->setValue(value); } - bool CSettingsComponent::loginAsObserver() const - { - return this->ui->rb_SettingsLoginStealthMode->isChecked(); - } - - bool CSettingsComponent::loginStealth() const - { - return this->ui->rb_SettingsLoginStealthMode->isChecked(); - } - int CSettingsComponent::getAtcUpdateIntervalSeconds() const { return this->ui->hs_SettingsGuiAtcRefreshTime->value(); @@ -92,11 +72,6 @@ namespace BlackGui return this->ui->hs_SettingsGuiUserRefreshTime->value(); } - QString CSettingsComponent::getOwnCallsignFromGui() const - { - return this->ui->le_SettingsAircraftCallsign->text(); - } - /* * Reload settings */ @@ -106,7 +81,6 @@ namespace BlackGui CSettingsNetwork nws = this->getIContextSettings()->getNetworkSettings(); // update servers - this->ui->tvp_SettingsTnServers->setSelectedServer(nws.getCurrentTrafficNetworkServer()); this->ui->tvp_SettingsTnServers->updateContainer(nws.getTrafficNetworkServers()); // update hot keys @@ -130,14 +104,12 @@ namespace BlackGui this->connect(this->getIContextSettings(), &IContextSettings::changedSettings, this, &CSettingsComponent::ps_changedSettings); // Opacity, intervals - bool connected = false; this->connect(this->ui->hs_SettingsGuiOpacity, &QSlider::valueChanged, this, &CSettingsComponent::changedWindowsOpacity); this->connect(this->ui->hs_SettingsGuiAircraftRefreshTime, &QSlider::valueChanged, this, &CSettingsComponent::changedAircraftsUpdateInterval); this->connect(this->ui->hs_SettingsGuiAtcRefreshTime, &QSlider::valueChanged, this, &CSettingsComponent::changedAtcStationsUpdateInterval); this->connect(this->ui->hs_SettingsGuiUserRefreshTime, &QSlider::valueChanged, this, &CSettingsComponent::changedUsersUpdateInterval); // Settings server - this->connect(this->ui->pb_SettingsTnCurrentServer, &QPushButton::released, this, &CSettingsComponent::ps_alterTrafficServer); this->connect(this->ui->pb_SettingsTnRemoveServer, &QPushButton::released, this, &CSettingsComponent::ps_alterTrafficServer); this->connect(this->ui->pb_SettingsTnSaveServer, &QPushButton::released, this, &CSettingsComponent::ps_alterTrafficServer); this->connect(this->ui->tvp_SettingsTnServers, &QTableView::clicked, this, &CSettingsComponent::ps_networkServerSelected); @@ -154,7 +126,7 @@ namespace BlackGui this->ui->cb_SettingsGuiFontSize->setCurrentText(QString::number(font.pointSize())); this->m_fontColor = QColor(CStyleSheetUtility::instance().fontColor()); this->ui->le_SettingsGuiFontColor->setText(this->m_fontColor.name()); - connected = this->connect(this->ui->cb_SettingsGuiFont, SIGNAL(currentFontChanged(QFont)), this, SLOT(ps_fontChanged())); + bool connected = this->connect(this->ui->cb_SettingsGuiFont, SIGNAL(currentFontChanged(QFont)), this, SLOT(ps_fontChanged())); Q_ASSERT(connected); connected = this->connect(this->ui->cb_SettingsGuiFontSize, SIGNAL(currentIndexChanged(QString)), this, SLOT(ps_fontChanged())); Q_ASSERT(connected); @@ -169,7 +141,7 @@ namespace BlackGui void CSettingsComponent::ps_networkServerSelected(QModelIndex index) { const CServer clickedServer = this->ui->tvp_SettingsTnServers->at(index); - this->ps_updateGuiSelectedServerTextboxes(clickedServer); + this->ui->frp_ServerForm->setServer(clickedServer); } /* @@ -177,20 +149,17 @@ namespace BlackGui */ void CSettingsComponent::ps_alterTrafficServer() { - CServer server = this->ps_selectedServerFromTextboxes(); - if (!server.isValidForLogin()) + CServer server = this->ui->frp_ServerForm->getServer(); + CStatusMessageList msgs = server.validate(); + if (!msgs.isEmpty()) { - CLogMessage().validationWarning("Wrong settings for server"); + CLogMessage(this).validations(msgs); return; } const QString path = CSettingUtilities::appendPaths(IContextSettings::PathNetworkSettings(), CSettingsNetwork::ValueTrafficServers()); QObject *sender = QObject::sender(); - if (sender == this->ui->pb_SettingsTnCurrentServer) - { - this->getIContextSettings()->value(path, CSettingsNetwork::CmdSetCurrentServer(), server.toQVariant()); - } - else if (sender == this->ui->pb_SettingsTnRemoveServer) + if (sender == this->ui->pb_SettingsTnRemoveServer) { this->getIContextSettings()->value(path, CSettingUtilities::CmdRemove(), server.toQVariant()); } @@ -210,42 +179,6 @@ namespace BlackGui Q_UNUSED(type); } - /* - * Textboxes from server - */ - void CSettingsComponent::ps_updateGuiSelectedServerTextboxes(const CServer &server) - { - this->ui->le_SettingsTnCsName->setText(server.getName()); - this->ui->le_SettingsTnCsDescription->setText(server.getDescription()); - this->ui->le_SettingsTnCsAddress->setText(server.getAddress()); - this->ui->le_SettingsTnCsPort->setText(QString::number(server.getPort())); - this->ui->le_SettingsTnCsRealName->setText(server.getUser().getRealName()); - this->ui->le_SettingsTnCsNetworkId->setText(server.getUser().getId()); - this->ui->le_SettingsTnCsPassword->setText(server.getUser().getPassword()); - } - - /* - * Server settings from textboxes - */ - CServer CSettingsComponent::ps_selectedServerFromTextboxes() const - { - CServer server; - bool portOk = false; - server.setName(this->ui->le_SettingsTnCsName->text()); - server.setDescription(this->ui->le_SettingsTnCsDescription->text()); - server.setAddress(this->ui->le_SettingsTnCsAddress->text()); - server.setPort(this->ui->le_SettingsTnCsPort->text().toInt(&portOk)); - if (!portOk) server.setPort(-1); - - CUser user; - user.setRealName(this->ui->le_SettingsTnCsRealName->text()); - user.setId(this->ui->le_SettingsTnCsNetworkId->text()); - user.setPassword(this->ui->le_SettingsTnCsPassword->text()); - server.setUser(user); - - return server; - } - /* * Save the hotkeys */ diff --git a/src/blackgui/components/settingscomponent.h b/src/blackgui/components/settingscomponent.h index 6d22e7ec7..bfdd0e07f 100644 --- a/src/blackgui/components/settingscomponent.h +++ b/src/blackgui/components/settingscomponent.h @@ -56,18 +56,9 @@ namespace BlackGui //! \copydoc CAudioSetupComponent::playNotificationSounds bool playNotificationSounds() const; - //! ICAO data from GUI - void setOwnAircraftIcaoDataFromGui(BlackMisc::Aviation::CAircraftIcao &icao) const; - //! GUI Opacity 0-100% void setGuiOpacity(double value); - //! Login as observer - bool loginAsObserver() const; - - //! Login as observer - bool loginStealth() const; - //! ATC refresh time int getAtcUpdateIntervalSeconds() const; @@ -77,9 +68,6 @@ namespace BlackGui //! Aircraft refresh time int getUsersUpdateIntervalSeconds() const; - //! Own callsign - QString getOwnCallsignFromGui() const; - signals: //! Change the windows opacity 0..100 void changedWindowsOpacity(int opacity); @@ -112,15 +100,6 @@ namespace BlackGui //! Alter traffic server void ps_alterTrafficServer(); - /*! - * \brief Update the selected server textboxes - * \param server to be displayed - */ - void ps_updateGuiSelectedServerTextboxes(const BlackMisc::Network::CServer &server); - - //! Selected server from textboxes - BlackMisc::Network::CServer ps_selectedServerFromTextboxes() const; - //! Settings have been changed void ps_changedSettings(uint typeValue); diff --git a/src/blackgui/components/settingscomponent.ui b/src/blackgui/components/settingscomponent.ui index e8481c8bf..4801e46b4 100644 --- a/src/blackgui/components/settingscomponent.ui +++ b/src/blackgui/components/settingscomponent.ui @@ -6,8 +6,8 @@ 0 0 - 338 - 323 + 359 + 269 @@ -20,7 +20,7 @@ Settings - 1 + 0 @@ -44,6 +44,12 @@ + + + 0 + 0 + + QAbstractItemView::AnyKeyPressed|QAbstractItemView::DoubleClicked|QAbstractItemView::EditKeyPressed @@ -59,119 +65,26 @@ - - - QFormLayout::AllNonFixedFieldsGrow + + + + 0 + 0 + - - 6 + + + 0 + 0 + - - 6 + + QFrame::StyledPanel - - 6 + + QFrame::Raised - - 6 - - - - - Name - - - - - - - - - - - - - - Description - - - - - - - - - - Address - - - - - - - - - - Port - - - - - - - 5 - - - - - - - Real name - - - - - - - - - - - - - - Id: - - - - - - - - - - - - - - Password - - - - - - - - - - 32 - - - QLineEdit::Password - - - - + @@ -188,6 +101,19 @@ 3 + + + + Qt::Horizontal + + + + 40 + 20 + + + + @@ -214,143 +140,11 @@ - - - - - 0 - 0 - - - - Current server - - - - - - Aircraft - - - - - - QFormLayout::AllNonFixedFieldsGrow - - - - - Callsign - - - - - - - Qt::ImhLatinOnly|Qt::ImhUppercaseOnly - - - BLACK - - - 20 - - - - - - - ICAO type (e.g. A320) - - - - - - - Qt::ImhUppercaseOnly - - - C172 - - - - - - - ICAO airline (e.g.DLH) - - - - - - - SGN - - - - - - - Aircraft type (e.g. L2J) - - - - - - - L1P - - - - - - - Login modes - - - - - - - - - - - - - Normal - - - true - - - - - - - Stealth mode - - - - - - - Observer - - - - - - - - - - Audio @@ -826,6 +620,12 @@
blackgui/components/settingssimulatorcomponent.h
1 + + BlackGui::CServerForm + QFrame +
blackgui/serverform.h
+ 1 +
diff --git a/src/blackgui/models/serverlistmodel.cpp b/src/blackgui/models/serverlistmodel.cpp index 98613d2f2..18ead6947 100644 --- a/src/blackgui/models/serverlistmodel.cpp +++ b/src/blackgui/models/serverlistmodel.cpp @@ -37,29 +37,5 @@ namespace BlackGui (void)QT_TRANSLATE_NOOP("ViewServerList", "userid"); } - /* - * Special functions - */ - QVariant CServerListModel::data(const QModelIndex &index, int role) const - { - if (role == Qt::BackgroundRole) - { - if (!this->hasSelectedServer()) return QVariant(); - CServer currentRow = this->at(index); - if (currentRow == this->getSelectedServer()) - { - QBrush background(Qt::green); - return background; - } - else - { - return QVariant(); - } - } - else - { - return CListModelBase::data(index, role); - } - } } // class } // namespace diff --git a/src/blackgui/models/serverlistmodel.h b/src/blackgui/models/serverlistmodel.h index 4bd1c546e..9f44c7065 100644 --- a/src/blackgui/models/serverlistmodel.h +++ b/src/blackgui/models/serverlistmodel.h @@ -24,9 +24,6 @@ namespace BlackGui class CServerListModel : public CListModelBase { - private: - BlackMisc::Network::CServer m_selectedServer; - public: //! Constructor @@ -34,27 +31,6 @@ namespace BlackGui //! Destructor virtual ~CServerListModel() {} - - //! Has selected server? - bool hasSelectedServer() const - { - return this->m_selectedServer.isValidForLogin(); - } - - //! Get selected server - const BlackMisc::Network::CServer &getSelectedServer() const - { - return this->m_selectedServer; - } - - //! Set selected server - void setSelectedServer(const BlackMisc::Network::CServer &selectedServer) - { - this->m_selectedServer = selectedServer; - } - - //! \copydoc CListModelBase::data - virtual QVariant data(const QModelIndex &index, int role) const override; }; } } diff --git a/src/blackgui/views/serverview.cpp b/src/blackgui/views/serverview.cpp index 4d79926e9..f4a011f48 100644 --- a/src/blackgui/views/serverview.cpp +++ b/src/blackgui/views/serverview.cpp @@ -21,11 +21,5 @@ namespace BlackGui { this->standardInit(new CServerListModel(this)); } - - void CServerView::setSelectedServer(const Network::CServer &selectedServer) - { - Q_ASSERT(this->m_model); - this->m_model->setSelectedServer(selectedServer); - } } -} +} // namespace diff --git a/src/blackgui/views/serverview.h b/src/blackgui/views/serverview.h index e1e360725..280dc3884 100644 --- a/src/blackgui/views/serverview.h +++ b/src/blackgui/views/serverview.h @@ -27,9 +27,6 @@ namespace BlackGui //! Constructor explicit CServerView(QWidget *parent = nullptr); - - //! \copydoc CServerListModel::setSelectedServer - void setSelectedServer(const BlackMisc::Network::CServer &selectedServer); }; } } diff --git a/src/blackmisc/setnetwork.cpp b/src/blackmisc/setnetwork.cpp index 7b0d26feb..3c9e0f26a 100644 --- a/src/blackmisc/setnetwork.cpp +++ b/src/blackmisc/setnetwork.cpp @@ -54,13 +54,7 @@ namespace BlackMisc void CSettingsNetwork::initDefaultValues() { this->m_trafficNetworkServers.clear(); - CServer currentServer(CServer("Testserver", "Client project testserver", "vatsim-germany.org", 6809, CUser("guest", "Guest Client project", "", "guest"))); - this->setCurrentNetworkServer(currentServer); - this->addTrafficNetworkServer(this->getCurrentTrafficNetworkServer()); - this->addTrafficNetworkServer(CServer("Europe C2", "VATSIM Server", "88.198.19.202", 6809, CUser("vatsimid", "Black Client", "", "vatsimpw"))); - this->addTrafficNetworkServer(CServer("Europe CC", "VATSIM Server", "5.9.155.43", 6809, CUser("vatsimid", "Black Client", "", "vatsimpw"))); - this->addTrafficNetworkServer(CServer("UK", "VATSIM Server", "109.169.48.148", 6809, CUser("vatsimid", "Black Client", "", "vatsimpw"))); - this->addTrafficNetworkServer(CServer("USA-W", "VATSIM Server", "64.151.108.52", 6809, CUser("vatsimid", "Black Client", "", "vatsimpw"))); + this->addTrafficNetworkServer(CServer("Testserver", "Client project testserver", "vatsim-germany.org", 6809, CUser("guest", "Guest Client project", "", "guest"))); } /* diff --git a/src/blackmisc/setnetwork.h b/src/blackmisc/setnetwork.h index 4ec31ba47..419372067 100644 --- a/src/blackmisc/setnetwork.h +++ b/src/blackmisc/setnetwork.h @@ -32,7 +32,11 @@ namespace BlackMisc //! Default constructor. CSettingsNetwork(); - //! Update + //! Destructor. + virtual ~CSettingsNetwork() {} + + //! Current server + //! \deprecated shall not be used anymore static const QString &CmdSetCurrentServer() { static const QString cmd("currenttrafficserver"); @@ -64,6 +68,7 @@ namespace BlackMisc BlackMisc::Network::CServerList getTrafficNetworkServers() const { return m_trafficNetworkServers; } //! Selected traffic network server + //! \deprecated Shall not be used anymore BlackMisc::Network::CServer getCurrentTrafficNetworkServer() const { return m_trafficNetworkServerCurrent; } //! URL of booking service