refs #77, refs #288 fixed gcc / doxygen warnings as far as possible

src/blackgui/components/logincomponent.cpp

@@ -183,6 +183,9 @@ namespace BlackGui
                 case INetwork::LoginAsObserver:
                     CLogMessage(this).info("login in observer mode");
                     break;
+                case INetwork::LoginNormal:
+                default:
+                    break;
                 }
 
                 // Server

src/blackgui/led.cpp

@@ -226,7 +226,7 @@ namespace BlackGui
 
     void CLedWidget::toggleValue()
     {
-        m_value = (m_value == Off) ? m_value = On : m_value = Off;
+        m_value = (m_value == Off) ? On : Off;
         setLed();
     }
 

src/blackgui/loginmodebuttons.h

@@ -21,7 +21,7 @@ namespace Ui { class CLoginModeButtons; }
 
 namespace BlackGui
 {
-
+    //! Display login modes (normal, stealth, ...)
     class CLoginModeButtons : public QGroupBox
     {
         Q_OBJECT

src/blackgui/uppercasevalidator.cpp

@@ -19,7 +19,7 @@ namespace BlackGui
     { }
 
     CUpperCaseValidator::CUpperCaseValidator(bool optionalValue, int minLength, int maxLength, QObject *parent) : QValidator(parent),
-        m_minLength(minLength), m_maxLength(maxLength), m_optionalValue(optionalValue)
+        m_optionalValue(optionalValue), m_minLength(minLength), m_maxLength(maxLength)
     { }
 
     QValidator::State CUpperCaseValidator::validate(QString &input, int &pos) const