Fixes of MS'review as proposed

https://dev.vatsim-germany.org/issues/368#change-2380 (1,2)
https://dev.vatsim-germany.org/issues/364#change-2379 (1-11,13)
This commit is contained in:
Klaus Basan
2015-01-18 22:02:07 +01:00
parent 054db94997
commit 4e1db5c837
19 changed files with 100 additions and 47 deletions

View File

@@ -14,6 +14,7 @@
#include "valueobject.h"
#include <QPixmap>
#include <QReadWriteLock>
namespace BlackMisc
{
@@ -28,6 +29,12 @@ namespace BlackMisc
//! Constructor.
CPixmap(const QPixmap &pixmap);
//! Copy constructor (because of mutex)
CPixmap(const CPixmap &other);
//! Copy assignment (because of mutex)
CPixmap &operator =(const CPixmap &other);
//! Corresponding pixmap
const QPixmap &pixmap() const;
@@ -52,6 +59,8 @@ namespace BlackMisc
mutable QPixmap m_pixmap; //!< cached pixmap, mutable because of lazy initialization
mutable bool m_hasCachedPixmap = false; //!< pixmap? Mutable because of lazy initialization
mutable QReadWriteLock m_lock; //!< lock (because of mutable members)
QByteArray m_array; //!< data of pixmap
};
} // namespace