From 5295473c4fa418deb2c5073642152310cd98a5c0 Mon Sep 17 00:00:00 2001 From: Mat Sutcliffe Date: Wed, 19 Dec 2018 18:54:35 +0000 Subject: [PATCH] Added fixme comments marking undefined behaviour in CColumn. --- src/blackgui/models/columns.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/blackgui/models/columns.cpp b/src/blackgui/models/columns.cpp index 886496ca1..f70d90cd0 100644 --- a/src/blackgui/models/columns.cpp +++ b/src/blackgui/models/columns.cpp @@ -46,16 +46,19 @@ namespace BlackGui const char *CColumn::getTranslationContextChar() const { + //! \fixme MS 2018-12 Undefined behaviour: returning pointer to temporary data deleted when function returns. return m_translationContext.toUtf8().constData(); } const char *CColumn::getColumnNameChar() const { + //! \fixme MS 2018-12 Undefined behaviour: returning pointer to temporary data deleted when function returns. return m_columnName.toUtf8().constData(); } const char *CColumn::getColumnToolTipChar() const { + //! \fixme MS 2018-12 Undefined behaviour: returning pointer to temporary data deleted when function returns. return m_columnToolTip.toUtf8().constData(); } @@ -219,6 +222,7 @@ namespace BlackGui const char *CColumns::getTranslationContextChar() const { + //! \fixme MS 2018-12 Undefined behaviour: returning pointer to temporary data deleted when function returns. return m_translationContext.toUtf8().constData(); } }