From 5521a20883d99fee8605464934428722e4ec0943 Mon Sep 17 00:00:00 2001 From: Mat Sutcliffe Date: Fri, 29 Mar 2019 22:50:33 +0000 Subject: [PATCH] Swap comparison order in case the value expensive to compare. --- src/blackmisc/valuecache.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/blackmisc/valuecache.cpp b/src/blackmisc/valuecache.cpp index a639a38a0..9d8aa9b22 100644 --- a/src/blackmisc/valuecache.cpp +++ b/src/blackmisc/valuecache.cpp @@ -703,7 +703,7 @@ namespace BlackMisc Q_ASSERT(QThread::currentThread() == thread()); if (timestamp == 0) { timestamp = QDateTime::currentMSecsSinceEpoch(); } - bool changed = element.m_value.read() != value || element.m_timestamp != timestamp; + bool changed = element.m_timestamp != timestamp || element.m_value.read() != value; if (! changed && ! save && ! ignoreValue) { return {}; } if (ignoreValue) { value = element.m_value.read(); }