Fix several gcc, cppcheck and clang warnings

src/blackcore/context_application_proxy.cpp

@@ -48,7 +48,7 @@ namespace BlackCore
         s = connection.connect(serviceName, IContextApplication::ObjectPath(), IContextApplication::InterfaceName(),
                                "componentChanged", this, SIGNAL(componentChanged(uint, uint)));
         Q_ASSERT(s);
-
+        Q_UNUSED(s);
     }
 
     /*

src/blackgui/components/atcstationcomponent.cpp

@@ -49,6 +49,7 @@ namespace BlackGui
             Q_ASSERT(connected);
             connected = this->connect(this->ui->pb_AtcStationsLoadMetar, SIGNAL(clicked()), this, SLOT(getMetar()));
             Q_ASSERT(connected);
+            Q_UNUSED(connected);
             connect(this, &QTabWidget::currentChanged, this, &CAtcStationComponent::ps_atcStationsTabChanged); // "local" tab changed (booked, online)
             connect(this->ui->tvp_AtcStationsOnline, &QTableView::clicked, this, &CAtcStationComponent::ps_onlineAtcStationSelected);
             connect(this->ui->tvp_AtcStationsOnline, &CAtcStationView::testRequestDummyAtcOnlineStations, this, &CAtcStationComponent::ps_testCreateDummyOnlineAtcStations);

src/blackgui/components/audiosetupcomponent.cpp

@@ -59,6 +59,7 @@ namespace BlackGui
                 Q_ASSERT(connected);
                 connected = this->connect(this->ui->cb_SetupAudioOutputDevice, SIGNAL(currentIndexChanged(int)), this, SLOT(ps_audioDeviceSelected(int)));
                 Q_ASSERT(connected);
+                Q_UNUSED(connected);
 
                 this->connect(this->ui->pb_SetupAudioMicrophoneTest, &QPushButton::clicked, this, &CAudioSetupComponent::ps_startAudioTest);
                 this->connect(this->ui->pb_SetupAudioSquelchTest, &QPushButton::clicked, this, &CAudioSetupComponent::ps_startAudioTest);

src/blackgui/components/audiovolumecomponent.cpp

@@ -49,6 +49,7 @@ namespace BlackGui
             // to audio audio context
             c = connect(this->ui->pb_Mute, &QPushButton::toggled, this->getIContextAudio(), &IContextAudio::setMute);
             Q_ASSERT(c);
+            Q_UNUSED(c);
         }
 
         void CAudioVolumeComponent::ps_onMuteChanged(bool muted)

src/blackgui/components/cockpitcomcomponent.cpp

@@ -171,7 +171,6 @@ namespace BlackGui
             }
             else if (this->getIContextAudio())
             {
-                CSelcal selcal(selcal);
                 this->getIContextAudio()->playSelcalTone(selcal);
             }
             else

src/blackgui/components/cockpittranspondermodeledscomponent.h

@@ -62,8 +62,8 @@ namespace BlackGui
             static const QString &ledsOriginator();
 
             QScopedPointer<BlackGui::CLedWidget> m_ledStandby;
-            QScopedPointer<BlackGui::CLedWidget> m_ledIdent;
             QScopedPointer<BlackGui::CLedWidget> m_ledModes;
+            QScopedPointer<BlackGui::CLedWidget> m_ledIdent;
 
         };
 

src/blackgui/components/settingscomponent.cpp

@@ -133,6 +133,7 @@ namespace BlackGui
             connected = this->connect(this->ui->cb_SettingsGuiFontStyle, SIGNAL(currentIndexChanged(QString)), this, SLOT(ps_fontChanged()));
             Q_ASSERT(connected);
             this->connect(this->ui->tb_SettingsGuiFontColor, &QToolButton::clicked, this, &CSettingsComponent::ps_fontColorDialog);
+            Q_UNUSED(connected);
         }
 
         /*

src/blackmisc/valueobject.cpp

@@ -64,7 +64,7 @@ namespace BlackMisc
 
         // not all classes have implemented nesting
         const QString m = QString("Property by index not found (setter), index: ").append(index.toQString());
-        qFatal(m.toLatin1().constData());
+        qFatal("%s", qPrintable(m));
     }
 
     /*
@@ -88,7 +88,7 @@ namespace BlackMisc
 
         // not all classes have implemented nesting
         const QString m = QString("Property by index not found, index: ").append(index.toQString());
-        qFatal(m.toLatin1().constData());
+        qFatal("%s", qPrintable(m));
         return QVariant(m); // avoid compiler warning
     }
 

src/plugins/simulator/fs9/fs9_host.cpp

@@ -159,8 +159,16 @@ namespace BlackSimPlugin
             if (m_hostStatus == Terminated) return hr;
 
             BlackMisc::CLogMessage(this).info("Hosting terminated!");
-            hr = m_directPlayPeer->TerminateSession(nullptr, 0, 0);
+            if (FAILED(hr = m_directPlayPeer->TerminateSession(nullptr, 0, 0)))
-            hr = m_directPlayPeer->Close(0);
+            {
+                return printDirectPlayError(hr);
+            }
+
+            if (FAILED(hr = m_directPlayPeer->Close(0)))
+            {
+                return printDirectPlayError(hr);
+            }
+
             m_hostStatus = Terminated;
 
             emit statusChanged(m_hostStatus);