flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-04-23 05:45:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Send slowfast before ordinary position update

Browse Source 
This solves a server-side performance issue.
This commit is contained in:
Mat Sutcliffe
2022-05-03 20:14:23 +01:00
parent 9a5ea83698
commit 59a27a0d72
2 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/blackcore/fsd/fsdclient.cpp
View File

@@ -355,6 +355,14 @@ namespace BlackCore::Fsd
} }
else else
{ {
if (this->isVisualPositionSendingEnabledForServer())
{
// Slowfast must be sent before the ordinary update.
// Sending after causes a server performance issue.
// See https://discord.com/channels/775552633918062643/775736423319732256/960746661259390996
sendVisualPilotDataUpdate(true);
}
PilotRating r = this->getPilotRating(); PilotRating r = this->getPilotRating();
PilotDataUpdate pilotDataUpdate(myAircraft.getTransponderMode(), PilotDataUpdate pilotDataUpdate(myAircraft.getTransponderMode(),
getOwnCallsignAsString(), getOwnCallsignAsString(),
@@ -371,11 +379,6 @@ namespace BlackCore::Fsd
myAircraft.getParts().isOnGround()); myAircraft.getParts().isOnGround());
sendQueudedMessage(pilotDataUpdate); sendQueudedMessage(pilotDataUpdate);
} }
if (this->isVisualPositionSendingEnabledForServer())
{
sendVisualPilotDataUpdate(true);
}
} }
void CFSDClient::sendInterimPilotDataUpdate() void CFSDClient::sendInterimPilotDataUpdate()

6
tests/blackcore/fsd/testfsdclient/testfsdclient.cpp
View File

@@ -445,7 +445,7 @@ namespace BlackFsdTest
m_client->sendPilotDataUpdate(); m_client->sendPilotDataUpdate();
QCOMPARE(spy.count(), 2); QCOMPARE(spy.count(), 2);
const QList<QVariant> arguments = spy.takeFirst(); const QList<QVariant> arguments = spy.takeLast();
QCOMPARE(arguments.size(), 1); QCOMPARE(arguments.size(), 1);
const CRawFsdMessage fsdMessage = arguments.at(0).value<CRawFsdMessage>(); const CRawFsdMessage fsdMessage = arguments.at(0).value<CRawFsdMessage>();
const QString fsdRawMessage = fsdMessage.getRawMessage(); const QString fsdRawMessage = fsdMessage.getRawMessage();
@@ -477,7 +477,7 @@ namespace BlackFsdTest
m_client->sendPilotDataUpdate(); m_client->sendPilotDataUpdate();
QCOMPARE(spy.count(), 2); QCOMPARE(spy.count(), 2);
QList<QVariant> arguments = spy.takeFirst(); QList<QVariant> arguments = spy.takeLast();
QCOMPARE(arguments.size(), 1); QCOMPARE(arguments.size(), 1);
CRawFsdMessage fsdMessage = arguments.at(0).value<CRawFsdMessage>(); CRawFsdMessage fsdMessage = arguments.at(0).value<CRawFsdMessage>();
@@ -510,7 +510,7 @@ namespace BlackFsdTest
m_client->sendPilotDataUpdate(); m_client->sendPilotDataUpdate();
QCOMPARE(spy.count(), 2); QCOMPARE(spy.count(), 2);
QList<QVariant> arguments = spy.takeFirst(); QList<QVariant> arguments = spy.takeLast();
QCOMPARE(arguments.size(), 1); QCOMPARE(arguments.size(), 1);
CRawFsdMessage fsdMessage = arguments.at(0).value<CRawFsdMessage>(); CRawFsdMessage fsdMessage = arguments.at(0).value<CRawFsdMessage>();