From 5a24e403124dfa1e069f0e1e695789d402f993de Mon Sep 17 00:00:00 2001
From: Klaus Basan <klaus.basan@klausbasan.de>
Date: Wed, 20 Dec 2017 04:16:01 +0100
Subject: [PATCH] Ref T210, cppcheck fixes

a) 23	performance	useInitializationList	false	Variable 'm_artifactsPilotClient' is assigned in constructor body. Consider performing initialization in initialization list.
b) 33	performance	passedByValue	false	Function parameter 'il' should be passed by reference.

a) is clear, but b) seems to be wrong, hidden by "cppcheck-suppress"
---
 src/blackmisc/db/updateinfo.cpp |  5 +++--
 src/blackmisc/platformset.cpp   | 11 +++++++++--
 src/blackmisc/platformset.h     |  2 +-
 3 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/src/blackmisc/db/updateinfo.cpp b/src/blackmisc/db/updateinfo.cpp
index 9b30c3d20..c17f46790 100644
--- a/src/blackmisc/db/updateinfo.cpp
+++ b/src/blackmisc/db/updateinfo.cpp
@@ -18,10 +18,11 @@ namespace BlackMisc
     namespace Db
     {
         CUpdateInfo::CUpdateInfo(const CArtifactList &artifacts, const CDistributionList &distributions) :
+            m_artifactsPilotClient(artifacts.findByType(CArtifact::PilotClientInstaller)),
+            m_artifactsXsb(artifacts.findByType(CArtifact::XSwiftBus)),
             m_distributions(distributions)
         {
-            m_artifactsPilotClient = artifacts.findByType(CArtifact::PilotClientInstaller);
-            m_artifactsXsb = artifacts.findByType(CArtifact::XSwiftBus);
+            // void
         }
 
         CDistributionList CUpdateInfo::getDistributionsPilotClientForCurrentPlatform() const
diff --git a/src/blackmisc/platformset.cpp b/src/blackmisc/platformset.cpp
index 41d8ed076..187e3d350 100644
--- a/src/blackmisc/platformset.cpp
+++ b/src/blackmisc/platformset.cpp
@@ -7,6 +7,8 @@
  * contained in the LICENSE file.
  */
 
+//! \cond PRIVATE
+
 #include "platformset.h"
 #include "blackmisc/containerbase.h"
 #include "blackmisc/dbus.h"
@@ -20,8 +22,11 @@ namespace BlackMisc
 {
     CPlatformSet::CPlatformSet() { }
 
-    CPlatformSet::CPlatformSet(const CCollection<CPlatform> &other) :
-        CCollection<CPlatform>(other)
+    // cppcheck-suppress passedByValue
+    CPlatformSet::CPlatformSet(std::initializer_list<CPlatform> il) : CCollection<CPlatform>(il)
+    { }
+
+    CPlatformSet::CPlatformSet(const CCollection<CPlatform> &other) : CCollection<CPlatform>(other)
     { }
 
     QStringList CPlatformSet::getPlatformNames() const
@@ -78,3 +83,5 @@ namespace BlackMisc
         registerMetaValueType<CPlatformSet>();
     }
 } // namespace
+
+//! \endcond
diff --git a/src/blackmisc/platformset.h b/src/blackmisc/platformset.h
index 19dba2607..fa0d5707a 100644
--- a/src/blackmisc/platformset.h
+++ b/src/blackmisc/platformset.h
@@ -30,7 +30,7 @@ namespace BlackMisc
         CPlatformSet();
 
         //! Initializer list constructor.
-        CPlatformSet(std::initializer_list<CPlatform> il) : CCollection<CPlatform>(il) {}
+        CPlatformSet(std::initializer_list<CPlatform> il);
 
         //! Construct from a base class object.
         CPlatformSet(const CCollection<CPlatform> &other);