refactor: Remove old comments

src/core/context/contextaudio.cpp

@@ -439,9 +439,6 @@ namespace swift::core::context
 
         m_voiceClient->setOutputMuted(muted);
         if (!muted) { m_voiceClient->setNormalizedMasterOutputVolume(m_outMasterVolumeBeforeMute); }
-
-        // signal no longer need, signaled by m_voiceClient->setMuted
-        // emit this->changedMute(muted);
     }
 
     bool CContextAudioBase::isOutputMuted() const
@@ -456,7 +453,7 @@ namespace swift::core::context
         const int ms = t.toMs();
         if (ms > 10)
         {
-            // As of https://dev.swift-project.org/T558 play additional notification
+            // Play additional notification
             const QPointer<const CContextAudioBase> myself(this);
             QTimer::singleShot(ms, this, [=] {
                 if (!sApp || sApp->isShuttingDown() || !myself) { return; }

src/core/db/databasereader.cpp

@@ -243,7 +243,6 @@ namespace swift::core::db
         // ps_read is implemented in the derived classes
         if (entities == CEntityFlags::NoEntity) { return; }
 
-        //! https://dev.swift-project.org/T490
         QPointer<CDatabaseReader> myself(this);
         QTimer::singleShot(0, this, [=] {
             if (!sApp || sApp->isShuttingDown() || !myself) { return; }

src/core/fsd/fsdclient.cpp

@@ -1082,7 +1082,7 @@ namespace swift::core::fsd
 
         // IVAO parts
         // https://discordapp.com/channels/539048679160676382/695961646992195644/707915838845485187
-        // https://dev.swift-project.org/w/knowhow/simandinterpolation/ivaoparts/
+        // https://github.com/swift-project/pilotclient/wiki/Knowledgebase-Simulation:-IVAO-parts
     }
 
     void CFSDClient::handleAtcDataUpdate(const QStringList &tokens)

src/gui/infoarea.cpp

@@ -532,11 +532,7 @@ namespace swift::gui
             // this->setParent(m_originalParent, this->windowFlags() & ~Qt::Window);
             this->setWindowFlags(this->windowFlags() & ~Qt::Window);
 
-            // RW: The line below is commented to prevent making this widget visible as a top window
+            if (this->parentWidget())
-            // in case it is constructed without parent or anchestor widget. Contrary to the comment,
-            // it does not seem to be necessary https://dev.vatsim-germany.org/issues/738
-            // KB 2018-12 with T447 T452 re-eanled the line again, but with parent condition
-            if (this->parentWidget()) // this line
             {
                 this->setVisible(true); // after redocking this is required
             }

src/gui/settings/dockwidgetsettings.h

@@ -115,10 +115,7 @@ namespace swift::gui::settings
     struct TDockWidget : public swift::misc::TSettingTrait<CDockWidgetSettings>
     {
         //! \copydoc swift::misc::TSettingTrait::key
-        static const char *key()
+        static const char *key() { return "guidockwidget/%Application%/%OwnerName%"; } // Key in data cache
-        {
-            return "guidockwidget/%Application%/%OwnerName%";
-        } // Key in data cache https://dev.vatsim-germany.org/issues/776
 
         //! \copydoc swift::misc::TSettingTrait::humanReadable
         static const QString &humanReadable()

src/misc/icons.cpp

@@ -955,11 +955,7 @@ namespace swift::misc
         return pm;
     }
 
-    const QPixmap &CIcons::modelExclude16()
+    const QPixmap &CIcons::modelExclude16() { return cross16(); }
-    {
-        // Alternative: static const QPixmap pm(":/diagona/icons/diagona/icons/paper-plane--minus.png");
-        return cross16();
-    }
 
     const QPixmap &CIcons::modelConverterX()
     {

src/misc/range.h

@@ -227,8 +227,7 @@ namespace swift::misc
         //! Create a range from reverse iterators.
         CRange<const_reverse_iterator> reverse() const
         {
-            static_assert(std::is_same_v<decltype(*rbegin()), decltype(*begin())>,
+            static_assert(std::is_same_v<decltype(*rbegin()), decltype(*begin())>, "");
-                          "see https://dev.swift-project.org/T700");
             return { rbegin(), rend() };
         }
 

src/misc/simulation/interpolation/interpolatorspline.cpp

@@ -139,8 +139,7 @@ namespace swift::misc::simulation
         if (latest.isNewerThanAdjusted(m_s[1])) { m_s[2] = latest; }
         const qint64 currentAdjusted = m_s[1].getAdjustedMSecsSinceEpoch();
 
-        // with https://dev.swift-project.org/T668#15841 avoid 2 very close positions
+        // avoid 2 very close positions currently done by time, maybe we can also choose distance
-        // currently done by time, maybe we can also choose distance
         const qint64 osNotTooClose = qRound64(0.8 * os);
         const CAircraftSituation older =
             m_currentSituations.findObjectBeforeAdjustedOrDefault(currentAdjusted - osNotTooClose);

src/misc/swiftdirectories.h

@@ -26,7 +26,6 @@ namespace swift::misc
         //! Returns the bin directory. On Windows/Linux this is the same directory as
         //! QCoreApplication::applicationDirPath(), but on MacOS the exceutable is
         //! located deeper in the hierarchy of the bundles
-        //! \see https://dev.swift-project.org/w/dev/swiftpc/dirstructure/
         static const QString &binDirectory();
 
         //! Plugins directory

src/misc/test/testing.cpp

@@ -40,7 +40,6 @@ namespace swift::misc::test
     CAtcStation CTesting::createStation(int index, bool byPropertyIndex)
     {
         // from WGS is slow, so static const (only 1 time init)
-        // https://dev.vatsim-germany.org/issues/322#note-2
         static const CCoordinateGeodetic geoPos =
             CCoordinateGeodetic::fromWgs84("48° 21′ 13″ N", "11° 47′ 09″ E", CAltitude(index, CLengthUnit::ft()));
         const QString cs = QStringLiteral("%1MI-SNO_TWR").arg(index);

src/misc/worker.cpp

@@ -174,7 +174,7 @@ namespace swift::misc
         setStarted();
         auto *thread = new CRegularThread(m_owner);
 
-        Q_ASSERT(m_owner); // must not be null, see (9) https://dev.vatsim-germany.org/issues/402
+        Q_ASSERT(m_owner); // must not be null
         if (m_owner)
         {
             const QString ownerName =

src/plugins/simulator/fscommon/fsuipcimpl.cpp

@@ -191,25 +191,6 @@ namespace swift::simplugin::fscommon
         bool situationN = !situation;
         bool aircraftPartsN = !aircraftParts;
 
-        /**  KB 2019-03 disabled as this should be fixed the whole block can be removed as soon this has been tested
-        //! \todo KB 2018-11 BUG fix for broken connection, needs to go as soon as issue is fixed
-        //! Seems to be fixed with
-        //! a) https://dev.swift-project.org/T471
-        //! b) https://dev.swift-project.org/T444
-        //! Remove after 2019-03 if issue is resolved
-        if (!(FSUIPC_Read(0x0238, 3, localFsTimeRaw, &dwResult) && FSUIPC_Process(&dwResult)))
-        {
-            FSUIPC_Close();
-            FSUIPC_Open(SIM_ANY, &dwResult);
-            m_closeCount++;
-            m_openCount++;
-            if (m_openCount < 10)
-            {
-                CLogMessage(this).warning(u"Used FSUIPC open/close workaround");
-            }
-        }
-        **/
-
         if (FSUIPC_Read(0x0238, 3, localFsTimeRaw, &dwResult) &&
 
             // COM settings

src/swiftguistandard/swiftguistd.h

@@ -337,6 +337,4 @@ private:
     //! @}
 };
 
-// #pragma pop_macro("interface")
-
 #endif // guard