incidental simplification

src/blackmisc/audiodevicelist.cpp

@@ -43,12 +43,10 @@ namespace BlackMisc
          */
         int CAudioDeviceList::count(CAudioDevice::DeviceType type) const
         {
-            int c = 0;
+            return std::count_if(this->begin(), this->end(), [type](const CAudioDevice &device)
-            foreach(CAudioDevice device, *this)
             {
-                if (device.getType() == type) c++;
+                return device.getType() == type;
-            }
+            });
-            return c;
         }
 
         /*

src/blackmisc/avairportlist.cpp

@@ -86,19 +86,10 @@ namespace BlackMisc
          */
         void CAirportList::removeIfOutsideRange(const Geo::CCoordinateGeodetic &position, const CLength &maxDistance, bool updateValues)
         {
-            CLength d;
+            this->removeIf([ & ](CAirport &airport)
-            for (CAirportList::iterator i = begin(); i != end();)
             {
-                d = i->calculcateDistanceAndBearingToPlane(position, updateValues);
+                return airport.calculcateDistanceAndBearingToPlane(position, updateValues) > maxDistance;
-                if (maxDistance < d)
+            });
-                {
-                    i = this->erase(i);
-                }
-                else
-                {
-                    ++i;
-                }
-            }
         }
     } // namespace
 } // namespace

src/blackmisc/nwtextmessagelist.cpp

@@ -132,12 +132,7 @@ namespace BlackMisc
         void CTextMessageList::toggleSenderRecipients()
         {
             if (this->isEmpty()) return;
-            for (int i = 0; i < this->size(); i++)
+            std::for_each(this->begin(), this->end(), [](CTextMessage &tm) { tm.toggleSenderRecipient(); });
-            {
-                CTextMessage tm = (*this)[i];
-                tm.toggleSenderRecipient();
-                (*this)[i] = tm;
-            }
         }
 
     } // namespace