flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-04-24 06:25:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix VS IDE warning/tip

Browse Source 
No need to return value from CUrl::appendQuery.
This commit is contained in:
Mat Sutcliffe
2019-10-03 19:11:38 +01:00
parent 712cc59dac
commit 641238116a
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/blackmisc/network/url.cpp
View File

@@ -95,19 +95,18 @@ namespace BlackMisc
return !m_query.isEmpty(); return !m_query.isEmpty();
} }
QString CUrl::appendQuery(const QString &queryToAppend) void CUrl::appendQuery(const QString &queryToAppend)
{ {
if (queryToAppend.isEmpty()) { return m_query; } if (queryToAppend.isEmpty()) { return; }
const QString q(stripQueryString(queryToAppend)); const QString q(stripQueryString(queryToAppend));
if (q.isEmpty()) { return m_query; } if (q.isEmpty()) { return; }
m_query += hasQuery() ? "&" + q : q; m_query += hasQuery() ? "&" + q : q;
return m_query;
} }
QString CUrl::appendQuery(const QString &key, const QString &value) void CUrl::appendQuery(const QString &key, const QString &value)
{ {
if (key.isEmpty()) { return m_query; } if (key.isEmpty()) { return; }
return this->appendQuery(key + "=" + value); this->appendQuery(key + "=" + value);
} }
QString CUrl::getFullUrl(bool withQuery) const QString CUrl::getFullUrl(bool withQuery) const

4
src/blackmisc/network/url.h
View File

@@ -106,10 +106,10 @@ namespace BlackMisc
bool hasQuery() const; bool hasQuery() const;
//! Append query //! Append query
QString appendQuery(const QString &queryToAppend); void appendQuery(const QString &queryToAppend);
//! Append query //! Append query
QString appendQuery(const QString &key, const QString &value); void appendQuery(const QString &key, const QString &value);
//! Empty //! Empty
bool isEmpty() const; bool isEmpty() const;