When calling arg() on a QString constructed from a literal, use QStringLiteral.

This commit is contained in:
Mat Sutcliffe
2018-12-20 21:32:39 +00:00
parent ace7650ebe
commit 6c05c5249d
99 changed files with 227 additions and 291 deletions

View File

@@ -48,8 +48,7 @@ namespace BlackGui
QString CGeneralGuiSettings::convertToQString(bool i18n) const
{
Q_UNUSED(i18n);
static const QString s("Widget style: %1");
return s.arg(this->m_widgetStyle);
return QStringLiteral("Widget style: %1").arg(this->m_widgetStyle);
}
BlackMisc::CVariant CGeneralGuiSettings::propertyByIndex(const BlackMisc::CPropertyIndex &index) const

View File

@@ -65,8 +65,7 @@ namespace BlackGui
QString CTextMessageSettings::convertToQString(bool i18n) const
{
Q_UNUSED(i18n);
static const QString s("Private: %1 supervisor: %2 frequency: %3 all: %4");
return s.arg(
return QStringLiteral("Private: %1 supervisor: %2 frequency: %3 all: %4").arg(
boolToOnOff(this->getPopupPrivateMessages()),
boolToOnOff(this->getPopupSupervisorMessages()),
boolToOnOff(this->getPopupFrequencyMessages()),