diff --git a/src/misc/valuecache.cpp b/src/misc/valuecache.cpp index cecfc29b5..bad6f181a 100644 --- a/src/misc/valuecache.cpp +++ b/src/misc/valuecache.cpp @@ -585,7 +585,7 @@ namespace swift::misc auto it = std::find_if(pages.cbegin(), pages.cend(), [cache](CValuePage *page) { return page->m_cache == cache; }); if (it == pages.cend()) { return *new CValuePage(parent, cache); } - else { return **it; } + return **it; } struct CValuePage::Element diff --git a/src/misc/valuecache.h b/src/misc/valuecache.h index 9ffa4bad0..9ea9ec37c 100644 --- a/src/misc/valuecache.h +++ b/src/misc/valuecache.h @@ -303,7 +303,6 @@ namespace swift::misc //! Mutex protecting operations which are critical on m_elements. mutable QRecursiveMutex m_mutex; - protected: //! Synchronously return a current value. //! \threadsafe CVariant getValueSync(const QString &key) { return std::get<0>(getValue(key)); }