From 88ec24bfb4ba845ae9d1fd0b8989ff005a2d6ea2 Mon Sep 17 00:00:00 2001
From: Lars Toenning <dev@ltoenning.de>
Date: Sat, 28 Dec 2024 17:03:53 +0100
Subject: [PATCH] refactor: Fix clang-tidy warnings

---
 src/misc/valuecache.cpp | 2 +-
 src/misc/valuecache.h   | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/misc/valuecache.cpp b/src/misc/valuecache.cpp
index cecfc29b5..bad6f181a 100644
--- a/src/misc/valuecache.cpp
+++ b/src/misc/valuecache.cpp
@@ -585,7 +585,7 @@ namespace swift::misc
         auto it =
             std::find_if(pages.cbegin(), pages.cend(), [cache](CValuePage *page) { return page->m_cache == cache; });
         if (it == pages.cend()) { return *new CValuePage(parent, cache); }
-        else { return **it; }
+        return **it;
     }
 
     struct CValuePage::Element
diff --git a/src/misc/valuecache.h b/src/misc/valuecache.h
index 9ffa4bad0..9ea9ec37c 100644
--- a/src/misc/valuecache.h
+++ b/src/misc/valuecache.h
@@ -303,7 +303,6 @@ namespace swift::misc
         //! Mutex protecting operations which are critical on m_elements.
         mutable QRecursiveMutex m_mutex;
 
-    protected:
         //! Synchronously return a current value.
         //! \threadsafe
         CVariant getValueSync(const QString &key) { return std::get<0>(getValue(key)); }