From 8c25f6b755e621be1213c37abb66b1493cf9cee6 Mon Sep 17 00:00:00 2001
From: Lars Toenning <dev@ltoenning.de>
Date: Mon, 23 Dec 2024 13:24:25 +0100
Subject: [PATCH] refactor: Remove unused network version function

---
 src/core/application.cpp                 |  6 +-----
 src/core/context/contextnetwork.h        |  3 ---
 src/core/context/contextnetworkempty.h   |  8 --------
 src/core/context/contextnetworkimpl.cpp  | 10 ----------
 src/core/context/contextnetworkimpl.h    |  3 ---
 src/core/context/contextnetworkproxy.cpp |  5 -----
 src/core/context/contextnetworkproxy.h   |  3 ---
 7 files changed, 1 insertion(+), 37 deletions(-)

diff --git a/src/core/application.cpp b/src/core/application.cpp
index 4b7ff0b26..1825eafde 100644
--- a/src/core/application.cpp
+++ b/src/core/application.cpp
@@ -509,11 +509,7 @@ namespace swift::core
                       QSysInfo::buildAbi() % separator % u"Build CPU: " % QSysInfo::buildCpuArchitecture() % separator %
                       CBuildConfig::compiledWithInfoLong();
 
-        if (this->supportsContexts())
-        {
-            str += (separator % u"Supporting contexts");
-            if (this->getIContextNetwork()) { str += (separator % this->getIContextNetwork()->getLibraryInfo(true)); }
-        }
+        if (this->supportsContexts()) { str += (separator % u"Supporting contexts"); }
 
         return str;
     }
diff --git a/src/core/context/contextnetwork.h b/src/core/context/contextnetwork.h
index e2c4658a8..96245152e 100644
--- a/src/core/context/contextnetwork.h
+++ b/src/core/context/contextnetwork.h
@@ -337,9 +337,6 @@ namespace swift::core::context
         //! Enable storing of aircraft parts
         virtual void enableAircraftPartsHistory(bool enabled) = 0;
 
-        //! Version of the underlying library (e.g. VATLIB)
-        virtual QString getLibraryInfo(bool detailed) const = 0;
-
         //! Statistics info
         virtual QString getNetworkStatistics(bool reset, const QString &separator) = 0;
 
diff --git a/src/core/context/contextnetworkempty.h b/src/core/context/contextnetworkempty.h
index bc12724f6..9bd95867c 100644
--- a/src/core/context/contextnetworkempty.h
+++ b/src/core/context/contextnetworkempty.h
@@ -251,14 +251,6 @@ namespace swift::core::context
         //! \copydoc IContextNetwork::requestAtisUpdates
         virtual void requestAtisUpdates() override { logEmptyContextWarning(Q_FUNC_INFO); }
 
-        //! \copydoc IContextNetwork::getLibraryInfo
-        virtual QString getLibraryInfo(bool detailed) const override
-        {
-            Q_UNUSED(detailed)
-            logEmptyContextWarning(Q_FUNC_INFO);
-            return QString("N/A");
-        }
-
         //! \copydoc IContextNetwork::testCreateDummyOnlineAtcStations
         virtual void testCreateDummyOnlineAtcStations(int number) override
         {
diff --git a/src/core/context/contextnetworkimpl.cpp b/src/core/context/contextnetworkimpl.cpp
index cd96aa881..d8de77c1f 100644
--- a/src/core/context/contextnetworkimpl.cpp
+++ b/src/core/context/contextnetworkimpl.cpp
@@ -1380,16 +1380,6 @@ namespace swift::core::context
         return m_fsdClient->getInterimPositionReceivers();
     }
 
-    QString CContextNetwork::getLibraryInfo(bool detailed) const
-    {
-        if (!this->canUseFsd()) { return QString(); }
-        if (this->isDebugEnabled())
-        {
-            CLogMessage(this, CLogCategories::contextSlot()).debug() << Q_FUNC_INFO << detailed;
-        }
-        return "";
-    }
-
     void CContextNetwork::testRequestAircraftConfig(const CCallsign &callsign)
     {
         if (!this->canUseFsd()) { return; }
diff --git a/src/core/context/contextnetworkimpl.h b/src/core/context/contextnetworkimpl.h
index 2051796a8..c96f53592 100644
--- a/src/core/context/contextnetworkimpl.h
+++ b/src/core/context/contextnetworkimpl.h
@@ -439,9 +439,6 @@ namespace swift::core
             //! \copydoc swift::core::context::IContextNetwork::getFastPositionEnabledCallsigns
             virtual swift::misc::aviation::CCallsignSet getFastPositionEnabledCallsigns() const override;
 
-            //! \copydoc swift::core::context::IContextNetwork::getLibraryInfo
-            virtual QString getLibraryInfo(bool detailed) const override;
-
             //! \copydoc swift::core::context::IContextNetwork::testCreateDummyOnlineAtcStations
             virtual void testCreateDummyOnlineAtcStations(int number) override;
 
diff --git a/src/core/context/contextnetworkproxy.cpp b/src/core/context/contextnetworkproxy.cpp
index eddc8a351..7132ec364 100644
--- a/src/core/context/contextnetworkproxy.cpp
+++ b/src/core/context/contextnetworkproxy.cpp
@@ -279,11 +279,6 @@ namespace swift::core::context
         return m_dBusInterface->callDBusRet<CAircraftPartsList>(QLatin1String("getRemoteAircraftParts"), callsign);
     }
 
-    QString CContextNetworkProxy::getLibraryInfo(bool detailed) const
-    {
-        return m_dBusInterface->callDBusRet<QString>(QLatin1String("getLibraryInfo"), detailed);
-    }
-
     bool CContextNetworkProxy::isAircraftPartsHistoryEnabled() const
     {
         return m_dBusInterface->callDBusRet<bool>(QLatin1String("isAircraftPartsHistoryEnabled"));
diff --git a/src/core/context/contextnetworkproxy.h b/src/core/context/contextnetworkproxy.h
index 9797e378c..14a377d94 100644
--- a/src/core/context/contextnetworkproxy.h
+++ b/src/core/context/contextnetworkproxy.h
@@ -226,9 +226,6 @@ namespace swift::core
             virtual swift::misc::aviation::CAircraftPartsList
             getRemoteAircraftParts(const swift::misc::aviation::CCallsign &callsign) const override;
 
-            //! \copydoc swift::core::context::IContextNetwork::getLibraryInfo
-            virtual QString getLibraryInfo(bool detailed) const override;
-
             //! \copydoc swift::core::context::IContextNetwork::isAircraftPartsHistoryEnabled
             virtual bool isAircraftPartsHistoryEnabled() const override;