flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-04-02 06:35:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

refs #624 Swap functions, move constructors, and move assignment operators should all be noexcept where possible.

Browse Source
This commit is contained in:
Mathew Sutcliffe
2016-03-21 01:24:43 +00:00
parent b33781717e
commit 91494ea2e5
10 changed files with 37 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/blackmisc/optional.h
View File

@@ -41,7 +41,7 @@ namespace BlackMisc
}
//! Move constructor.
Optional(Optional &&other) : m_isValid(other.m_isValid)
Optional(Optional &&other) noexcept(std::is_nothrow_move_constructible<T>::value) : m_isValid(other.m_isValid)
{
if (other.m_isValid) { new (m_data.bytes) T(std::move(*other)); }
}
@@ -64,7 +64,7 @@ namespace BlackMisc
}
//! Move assignment.
Optional &operator =(Optional &&other)
Optional &operator =(Optional &&other) noexcept(std::is_nothrow_move_assignable<T>::value)
{
if (m_isValid) { (*this)->~T(); }
if (other.m_isValid) { new (m_data.bytes) T(std::move(*other)); }
@@ -113,6 +113,7 @@ namespace BlackMisc
/*!
* Efficient swap for two Optional objects.
* \todo Make conditionally noexcept using C++17 std::is_nothrow_swappable.
*/
template <typename T>
void swap(Optional<T> &a, Optional<T> &b)