From a3fbbd7a672bbdbd7d7f4cd57732c61b5879d44f Mon Sep 17 00:00:00 2001
From: Roland Winklmeier <Roland.M.Winklmeier@gmail.com>
Date: Wed, 29 Jun 2016 16:51:33 +0200
Subject: [PATCH] Improve logging when parsing VATSIM METARs

refs #689
---
 src/blackcore/vatsim/vatsimmetarreader.cpp | 24 +++++-----------------
 1 file changed, 5 insertions(+), 19 deletions(-)

diff --git a/src/blackcore/vatsim/vatsimmetarreader.cpp b/src/blackcore/vatsim/vatsimmetarreader.cpp
index b998c74a8..589e0bf9c 100644
--- a/src/blackcore/vatsim/vatsimmetarreader.cpp
+++ b/src/blackcore/vatsim/vatsimmetarreader.cpp
@@ -119,39 +119,25 @@ namespace BlackCore
                     return;
                 }
 
-                QString invalidMetars;
-                int invalidLineCount = 0;
                 CMetarList metars;
+                int invalidLines = 0;
                 QTextStream lineReader(&metarData);
                 while (!lineReader.atEnd())
                 {
                     if (this->isAbandoned()) { return; }
                     QString line = lineReader.readLine();
                     CMetar metar = m_metarDecoder.decode(line);
-                    if (metar != CMetar())
-                    {
-                        metars.push_back(metar);
-                    }
-                    else
-                    {
-                        invalidMetars += line;
-                        invalidMetars += "\n";
-                        invalidLineCount++;
-                    }
+                    if (metar != CMetar()) { metars.push_back(metar); }
+                    else { invalidLines++; }
                 }
 
+                CLogMessage(this).debug() << "METAR statistic: " << metars.size() << "Metars ( invalid:" << invalidLines << ")";
+
                 {
                     QWriteLocker l(&m_lock);
                     m_metars = metars;
                 }
 
-                // I could use those for logging, etc.
-                Q_UNUSED(invalidMetars);
-                if (invalidLineCount > 0)
-                {
-                    // Regular issue, log it, but do not show to user
-                    CLogMessage(this).debug() << "Reading METARs failed for entries" << invalidLineCount;
-                }
                 emit metarsRead(metars);
                 emit dataRead(CEntityFlags::MetarEntity, CEntityFlags::ReadFinished, metars.size());
             }