From a65be602bb3aa49f443789d777e7683fa94ccba8 Mon Sep 17 00:00:00 2001 From: Mat Sutcliffe Date: Wed, 19 Dec 2018 18:44:51 +0000 Subject: [PATCH] Fixed clazy warnings: provide receiver object argument to signal/slot connection. --- src/blackcore/context/contextapplication.cpp | 8 ++++---- src/blackcore/webdataservices.cpp | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/blackcore/context/contextapplication.cpp b/src/blackcore/context/contextapplication.cpp index 36add582c..5cddbadd7 100644 --- a/src/blackcore/context/contextapplication.cpp +++ b/src/blackcore/context/contextapplication.cpp @@ -80,20 +80,20 @@ namespace BlackCore m_logSubscriptions[subscriber].removeAll(pattern); }); - connect(CSettingsCache::instance(), &CSettingsCache::valuesChangedByLocal, [ = ](const CValueCachePacket & settings) + connect(CSettingsCache::instance(), &CSettingsCache::valuesChangedByLocal, this, [ = ](const CValueCachePacket & settings) { if (!myself) { return; } this->changeSettings(settings, {}); }); - connect(this, &IContextApplication::settingsChanged, [](const CValueCachePacket & settings, const CIdentifier & origin) + connect(this, &IContextApplication::settingsChanged, CSettingsCache::instance(), [](const CValueCachePacket & settings, const CIdentifier & origin) { // Intentionally don't check for round trip here CSettingsCache::instance()->changeValuesFromRemote(settings, origin); }); Q_ASSERT_X(sApp && sApp->getInputManager(), Q_FUNC_INFO, "Missing input manager"); - bool s = connect(sApp->getInputManager(), &CInputManager::hotkeyActionRegistered, [ = ](const QStringList & actions) + bool s = connect(sApp->getInputManager(), &CInputManager::hotkeyActionRegistered, this, [ = ](const QStringList & actions) { if (!myself) { return; } this->registerHotkeyActions(actions, {}); @@ -101,7 +101,7 @@ namespace BlackCore Q_ASSERT_X(s, Q_FUNC_INFO, "Connect hotkey action failed"); Q_UNUSED(s); - s = connect(this, &IContextApplication::hotkeyActionsRegistered, [ = ](const QStringList & actions, const CIdentifier & origin) + s = connect(this, &IContextApplication::hotkeyActionsRegistered, sApp->getInputManager(), [ = ](const QStringList & actions, const CIdentifier & origin) { if (origin.hasApplicationProcessId()) { return; } sApp->getInputManager()->registerRemoteActions(actions); diff --git a/src/blackcore/webdataservices.cpp b/src/blackcore/webdataservices.cpp index f9915e479..0cdaa3d7d 100644 --- a/src/blackcore/webdataservices.cpp +++ b/src/blackcore/webdataservices.cpp @@ -1340,7 +1340,7 @@ namespace BlackCore if (m_shuttingDown) { return; } if (entities == CEntityFlags::NoEntity) { return; } const QPointer myself(this); - QTimer::singleShot(delayMs, [ = ]() + QTimer::singleShot(delayMs, [ = ]() // clazy:exclude=connect-3arg-lambda { if (!myself || m_shuttingDown) { return; } this->readInBackground(entities); // deferred