refactor(ui): Do not allow to overwrite FSD settings from connect page

Overwriting FSD settings from the connect page (instead of changing the
server settings itself) introduced some complexity in the UI. As
spontaniously changing the FSD settings is likely a VERY rare use-case
and to simplify the logic/UI, it should only be done from the server
settings itself.
This commit is contained in:
Lars Toenning
2024-08-23 21:43:37 +02:00
parent 6f73a99895
commit a75ccb9927
9 changed files with 1 additions and 302 deletions

View File

@@ -81,9 +81,6 @@ namespace BlackGui::Components
this->setForceSmall(true);
this->showKillButton(false);
// override details
ui->comp_NetworkDetails->setAlwaysAllowOverride(true);
// Stored data
this->loadRememberedUserData();
@@ -156,13 +153,6 @@ namespace BlackGui::Components
const CUser user = this->getUserFromPilotGuiValues();
currentServer.setUser(user);
// FSD setup, then override
if (ui->comp_NetworkDetails->isFsdSetupOverrideEnabled())
{
const CFsdSetup fsd = ui->comp_NetworkDetails->getFsdSetup();
currentServer.setFsdSetup(fsd);
}
// update for own aircraft context
sGui->getIContextOwnAircraft()->updateOwnAircraftPilot(currentServer.getUser());
@@ -226,11 +216,6 @@ namespace BlackGui::Components
}
}
void CLoginAdvComponent::resetState()
{
ui->comp_NetworkDetails->resetState();
}
void CLoginAdvComponent::loadRememberedUserData()
{
const CServer lastServer = m_networkSetup.getLastServer();