From cd13d18b0092680fe67d4a437ecfad260d94c4e6 Mon Sep 17 00:00:00 2001
From: Mathew Sutcliffe <oktal3700@gmail.com>
Date: Wed, 8 Nov 2017 19:00:36 +0000
Subject: [PATCH] Ref T184 Cache the result of QHostInfo::localHostName as it
 is expensive to call.

---
 src/blackmisc/identifier.cpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/blackmisc/identifier.cpp b/src/blackmisc/identifier.cpp
index 92611c654..e0c1dfd84 100644
--- a/src/blackmisc/identifier.cpp
+++ b/src/blackmisc/identifier.cpp
@@ -14,13 +14,20 @@
 #include <QHostInfo>
 #include <QStringBuilder>
 
+//! \private
+const QString &cachedLocalHostName()
+{
+    static const QString hostName = QHostInfo::localHostName();
+    return hostName;
+}
+
 namespace BlackMisc
 {
     CIdentifier::CIdentifier(const QString &name)
         : ITimestampBased(QDateTime::currentMSecsSinceEpoch()),
           m_name(name.trimmed()),
           m_machineIdBase64(QDBusConnection::localMachineId().toBase64()),
-          m_machineName(QHostInfo::localHostName()),
+          m_machineName(cachedLocalHostName()),
           m_processName(QCoreApplication::applicationName()),
           m_processId(QCoreApplication::applicationPid())
     { }