diff --git a/src/misc/aviation/altitude.cpp b/src/misc/aviation/altitude.cpp index 670835630..eb8377080 100644 --- a/src/misc/aviation/altitude.cpp +++ b/src/misc/aviation/altitude.cpp @@ -216,7 +216,7 @@ namespace swift::misc::aviation // in same step get numeric value only bool beforeDigit = true; QString numericPart; - for (int i = 0; i < v.length(); i++) + for (int i = 0; i < v.length(); i++) // NOLINT { const QChar c = v[i]; if (c.isDigit()) diff --git a/src/misc/aviation/selcal.cpp b/src/misc/aviation/selcal.cpp index 7fc00fff4..d2f9bdaab 100644 --- a/src/misc/aviation/selcal.cpp +++ b/src/misc/aviation/selcal.cpp @@ -39,7 +39,7 @@ namespace swift::misc::aviation QList f; if (!CSelcal::isValidCode(m_code)) return f; f.reserve(m_code.length()); - for (int pos = 0; pos < m_code.length(); pos++) { f.append(CSelcal::audioFrequencyEquivalent(m_code.at(pos))); } + for (const QChar c : m_code) { f.append(CSelcal::audioFrequencyEquivalent(c)); } return f; } diff --git a/src/misc/simulation/fscommon/bcdconversions.h b/src/misc/simulation/fscommon/bcdconversions.h index ccbd8e31d..fc017ec7e 100644 --- a/src/misc/simulation/fscommon/bcdconversions.h +++ b/src/misc/simulation/fscommon/bcdconversions.h @@ -40,7 +40,7 @@ namespace swift::misc private: //! Constructor, only static methods - CBcdConversions() {} + CBcdConversions() {} // NOLINT(modernize-use-equals-default) //! Horner scheme static quint32 hornerScheme(quint32 num, quint32 divider, quint32 factor); diff --git a/src/misc/simulation/interpolation/interpolationsetupprovider.h b/src/misc/simulation/interpolation/interpolationsetupprovider.h index 1abd8f665..3425e792f 100644 --- a/src/misc/simulation/interpolation/interpolationsetupprovider.h +++ b/src/misc/simulation/interpolation/interpolationsetupprovider.h @@ -118,7 +118,7 @@ namespace swift::misc::simulation protected: //! Default constructor - CInterpolationSetupAware() {} + CInterpolationSetupAware() {} // NOLINT(modernize-use-equals-default) //! Constructor CInterpolationSetupAware(IInterpolationSetupProvider *setupProvider) : IProviderAware(setupProvider) {} diff --git a/src/misc/variant.cpp b/src/misc/variant.cpp index db9723828..c9edd4c48 100644 --- a/src/misc/variant.cpp +++ b/src/misc/variant.cpp @@ -498,8 +498,7 @@ namespace swift::misc bool CVariant::isA(int metaTypeId) const { if (metaTypeId == QMetaType::UnknownType) { return false; } - if (metaTypeId == getMetaTypeId()) { return true; } - return false; + return metaTypeId == getMetaTypeId(); } bool CVariant::matches(const CVariant &value) const