flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-04-27 19:25:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use if constexpr (C++17 feature)

Browse Source
This commit is contained in:
Mat Sutcliffe
2021-04-17 21:57:20 +01:00
parent 5d67cd9f68
commit d7a461ff7a
11 changed files with 103 additions and 189 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/blackmisc/propertyindexref.h
View File

@@ -17,31 +17,6 @@
namespace BlackMisc
{
class CPropertyIndexRef;
namespace Private
{
//! \private
template <class T, class X>
int compareByProperty(const T &a, const T &b, const CPropertyIndexRef &index, std::true_type, X)
{
return a.comparePropertyByIndex(index, b);
}
//! \private
template <class T>
int compareByProperty(const T &a, const T &b, const CPropertyIndexRef &index, std::false_type, std::true_type)
{
return compare(a.propertyByIndex(index), b.propertyByIndex(index));
}
//! \private
template <class T>
int compareByProperty(const T &, const T &, const CPropertyIndexRef &, std::false_type, std::false_type)
{
qFatal("Not implemented");
return 0;
}
}
/*!
* Non-owning reference to a CPropertyIndex with a subset of its features.
*/
@@ -205,7 +180,15 @@ namespace BlackMisc
return [index = *this](const auto & a, const auto & b)
{
using T = std::decay_t<decltype(a)>;
return Private::compareByProperty(a, b, index, THasComparePropertyByIndex<T>(), THasPropertyByIndex<T>());
if constexpr (THasComparePropertyByIndex<T>::value)
{
return a.comparePropertyByIndex(index, b);
}
else if constexpr (THasPropertyByIndex<T>::value)
{
return compare(a.propertyByIndex(index), b.propertyByIndex(index));
}
else { qFatal("Not implemented"); return 0; }
};
}