flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-03-31 12:55:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Correctly remove session cache value of expired session.

Browse Source 
Summary:
`CDataCacheRevision` stores current working timestamps in `m_timestamps` and stores complete timestamps (including unadmitted deferred values) in `m_originalTimestamps`. A value is "in" the cache if and only if its timestamp is in `m_timestamps`. In `writeNewRevision` the `.rev` file is written based on `m_originalTimestamps` so that unadmitted deferred values don't get lost.

Session cache works by removing timestamps that were not created in the current session. But it needs to remove from both `m_timestamps` and `m_originalTimestamps` so that old session cache values can't get recreated by `writeNewRevision`.

Test Plan: Currently being evaluated by @kbasan to check that it does not introduce unintended consequences.

Reviewers: #swift_pilot_client, kbasan

Reviewed By: #swift_pilot_client, kbasan

Subscribers: jenkins, kbasan

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D53
This commit is contained in:
Mathew Sutcliffe
2017-09-12 16:43:06 +01:00
parent e98662d530
commit de11f7fe35
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/blackmisc/datacache.cpp
View File

@@ -429,7 +429,11 @@ namespace BlackMisc
for (auto it = sessionIds.cbegin(); it != sessionIds.cend(); ++it)
{
m_sessionValues[it.key()] = it.value();
if (it.value() != m_session->uuid()) { m_timestamps.remove(it.key()); }
if (it.value() != m_session->uuid())
{
m_timestamps.remove(it.key());
m_originalTimestamps.remove(it.key());
}
}
}
else if (revisionFile.size() > 0)