From e2b5cfb4d6416348e87ec638f4cac7a60d1fadbf Mon Sep 17 00:00:00 2001
From: Lars Toenning <dev@ltoenning.de>
Date: Tue, 7 Nov 2023 21:11:55 +0100
Subject: [PATCH] Remove redundant default initialization

---
 src/blackmisc/audio/audiosettings.cpp | 11 -----------
 src/blackmisc/audio/audiosettings.h   |  5 +----
 2 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/src/blackmisc/audio/audiosettings.cpp b/src/blackmisc/audio/audiosettings.cpp
index eccdc62ee..6835849c5 100644
--- a/src/blackmisc/audio/audiosettings.cpp
+++ b/src/blackmisc/audio/audiosettings.cpp
@@ -28,11 +28,6 @@ namespace BlackMisc::Audio
         return v;
     }
 
-    CSettings::CSettings()
-    {
-        this->initDefaultValues();
-    }
-
     bool CSettings::isNotificationFlagSet(CNotificationSounds::NotificationFlag notification) const
     {
         return this->getNotification().testFlag(notification);
@@ -112,10 +107,4 @@ namespace BlackMisc::Audio
         return u"Notification flags: " % CNotificationSounds::toString(this->getNotification()) %
                u" volume: " % QString::number(m_notificationVolume);
     }
-
-    void CSettings::initDefaultValues()
-    {
-        this->setNotification(CNotificationSounds::AllNotifications);
-        m_notificationVolume = 90;
-    }
 } // namespace
diff --git a/src/blackmisc/audio/audiosettings.h b/src/blackmisc/audio/audiosettings.h
index 5ea1d1715..ca6c86106 100644
--- a/src/blackmisc/audio/audiosettings.h
+++ b/src/blackmisc/audio/audiosettings.h
@@ -39,7 +39,7 @@ namespace BlackMisc::Audio
         //! @}
 
         //! Default constructor.
-        CSettings();
+        CSettings() = default;
 
         //! Notification flag (play notification?)
         bool isNotificationFlagSet(CNotificationSounds::NotificationFlag notification) const;
@@ -119,9 +119,6 @@ namespace BlackMisc::Audio
         //! Audio effects
         void setAudioEffectsEnabled(bool enabled) { m_audioEffects = enabled; }
 
-        //! Init with meaningful default values
-        void initDefaultValues();
-
         //! \copydoc BlackMisc::Mixin::String::toQString
         QString convertToQString(bool i18n = false) const;